Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: AppClient, AppFactory, AppDeployer interface and various refinements on top of existing new interfaces #124

Merged

Conversation

aorumbayev
Copy link
Contributor

Proposed Changes

  • AppClient interface implementation

Further notes

  • Adding a batch of unit tests mirroring tests on utils-ts

@aorumbayev aorumbayev force-pushed the prerelease/ts-feature-parity-appclient branch from 04f8457 to 52a6d7d Compare December 3, 2024 20:07
@aorumbayev aorumbayev force-pushed the prerelease/ts-feature-parity-appclient branch from 0dc0a65 to 078be72 Compare December 5, 2024 11:41
@aorumbayev aorumbayev force-pushed the prerelease/ts-feature-parity-appclient branch from 078be72 to 6d27062 Compare December 5, 2024 11:51
@aorumbayev aorumbayev force-pushed the prerelease/ts-feature-parity-appclient branch from 0c04d5c to cd2e772 Compare December 7, 2024 23:48
@aorumbayev aorumbayev force-pushed the prerelease/ts-feature-parity-appclient branch from 25c084b to aad3ca1 Compare December 9, 2024 14:37
@aorumbayev aorumbayev force-pushed the prerelease/ts-feature-parity-appclient branch from c4793af to 8f49afc Compare December 10, 2024 02:12
Copy link

github-actions bot commented Dec 10, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
src/algokit_utils
   _debugging.py140795%20, 41, 76, 80, 89, 129, 157
   application_client.py110%1
   config.py882374%28–30, 43, 55, 86–87, 102, 107, 112, 120–125, 156–165
   deploy.py110%1
   logic_error.py110%1
src/algokit_utils/_legacy_v2
   _ensure_funded.py71199%100
   _transfer.py67396%13, 76–77
   account.py931386%15–18, 70–74, 109, 126, 156, 159, 208
   application_client.py5327786%60–61, 178, 183, 212, 324, 329–330, 332, 334, 799, 814, 832–835, 925, 965, 977, 990, 1032, 1092–1098, 1102–1107, 1109, 1145, 1152, 1265, 1299, 1313, 1351–1353, 1355, 1365–1422, 1433–1438, 1458–1461
   application_specification.py991189%93, 95, 198–207, 211
   asset.py82594%10, 28–31
   common.py13192%13
   deploy.py4332295%32–35, 170, 174–175, 193, 249, 339–340, 361, 395, 406–414, 429, 437, 630–631, 655
   logic_error.py41295%10, 33
   network_clients.py73593%77–78, 101–102, 135
src/algokit_utils/accounts
   account_manager.py1582684%65–66, 81–84, 98, 113–117, 136, 141–148, 247, 277, 368, 433, 438, 475
   kmd_account_manager.py70889%55–59, 108, 181, 188
src/algokit_utils/applications
   app_client.py68415577%46–59, 97, 105, 341–344, 347, 350, 353, 356, 368, 377, 398–456, 489–491, 500–503, 506–507, 510–513, 516–517, 520–521, 524–525, 538, 600–601, 630, 633, 636, 639, 642, 645, 658, 661, 664, 667, 670, 673, 702–709, 712, 717, 722, 727, 732, 747, 770, 847, 882, 901, 903, 909, 941–944, 989, 1004, 1071–1078, 1103, 1115, 1117, 1120, 1124, 1157, 1182, 1246, 1264–1265, 1303, 1314–1316, 1320–1344, 1355, 1364–1375, 1383–1388
   app_deployer.py2223883%175, 182, 192–197, 200–204, 242–256, 271, 342–355, 365, 370, 376, 382–384, 535, 549, 560–598
   app_factory.py3172692%246, 256, 259, 383, 387, 391, 403, 556, 578–583, 589–590, 624, 632–633, 636, 666, 674–685
   app_manager.py2321594%63, 221, 251–252, 269–274, 295, 331, 344–347, 359, 367
   utils.py1788055%42, 44–45, 61, 90–91, 99, 106, 108, 110, 114–115, 122–141, 150, 153–159, 167–180, 186–198, 206–217, 267–270, 284, 364
src/algokit_utils/assets
   asset_manager.py1261290%221–222, 231, 237–252, 262
src/algokit_utils/clients
   algorand_client.py941485%80–81, 90–91, 112–114, 123–124, 182, 224, 240, 253, 263
   client_manager.py1363276%48–55, 61, 85–87, 117, 122–125, 139, 166, 178, 192, 208–231, 257, 269, 278
   dispenser_api_client.py821285%113–114, 118–121, 156–158, 177–179
src/algokit_utils/errors
   logic_error.py631379%13, 46, 98, 113–129
src/algokit_utils/models
   amount.py1145651%20, 32, 36, 60, 65–68, 72, 75–81, 88, 91–95, 98–102, 105–109, 112–116, 119–123, 126–132, 135–138, 141–147
   application.py266698%63, 202, 304, 363, 368, 408
src/algokit_utils/protocols
   application.py41880%9–17
src/algokit_utils/transactions
   models.py45491%45, 55, 75, 80
   transaction_composer.py5657687%28–37, 566, 581, 615–647, 779–780, 783, 806–807, 871, 897–912, 986, 989, 994, 997, 1001, 1004, 1030–1063, 1163, 1166, 1276, 1278–1279, 1323–1324
   transaction_creator.py71692%115, 120, 125, 130, 135, 140
   transaction_sender.py135993%159, 200–201, 290–295, 300–301, 325
   utils.py16814812%20–235, 241–268, 279, 282, 287, 291–302
TOTAL568691784% 

Tests Skipped Failures Errors Time
305 0 💤 0 ❌ 0 🔥 3m 19s ⏱️

@aorumbayev aorumbayev marked this pull request as ready for review December 11, 2024 17:15
@aorumbayev aorumbayev changed the title [DRAFT] feat: AppClient interface feat: AppClient, AppFactory, AppDeployer interface and various refinements on top of existing new interfaces Dec 11, 2024
@aorumbayev aorumbayev merged commit 62c121a into prerelease/ts-feature-parity Dec 11, 2024
4 checks passed
@aorumbayev aorumbayev deleted the prerelease/ts-feature-parity-appclient branch December 11, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant