Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: task send transaction(s) #326

Merged
merged 7 commits into from
Oct 12, 2023
Merged

Conversation

aorumbayev
Copy link
Collaborator

@aorumbayev aorumbayev commented Oct 11, 2023

Proposed changes

  • Adding ability to send transactions from goal clerk compatible signed txn objects
  • Supports inputs via --file, --transaction options OR piped input

Extra fixes

  • Adding custom json encoder for sign method when confirmation popup shows up to display canonical goal clerk compatible txn fields AND fix the bug that would crash on encoding of AppCall transactions

@aorumbayev aorumbayev requested a review from robdmoore October 11, 2023 13:18
@github-actions
Copy link

github-actions bot commented Oct 11, 2023

Coverage

Coverage Report
FileStmtsMissCoverMissing
src/algokit
   __init__.py15753%6–13, 17–24, 32–34
   __main__.py220%1–3
src/algokit/cli
   completions.py108298%83, 98
   deploy.py72790%44, 46, 89–91, 155, 179
   dispenser.py118199%75
   doctor.py48394%142–144
   generate.py57198%116
   goal.py39197%57
   init.py1901692%272–273, 323, 326–328, 339, 383, 409, 449, 458–460, 463–468, 481
   localnet.py93397%162, 183–184
src/algokit/cli/tasks
   send_transaction.py641084%48–49, 53, 85, 150, 162–166
   sign_transaction.py59886%21, 28–30, 71–72, 109, 123
   transfer.py35391%24, 82, 108
   utils.py883560%22–33, 37–38, 68–69, 93–94, 118–126, 147–156, 203, 260–265, 276–277
   vanity_address.py52590%41, 45–48
   wallet.py79495%21, 66, 136, 162
src/algokit/core
   bootstrap.py1612485%103–104, 126, 149, 214, 217, 223–237, 246–251
   conf.py54885%10, 24, 28, 36, 38, 71–73
   deploy.py691184%61–64, 73–75, 79, 84, 91–93
   dispenser.py2022687%91, 123–124, 141–149, 191–192, 198–200, 218–219, 259–260, 318, 332–334, 345–346, 356, 369, 384
   doctor.py65789%67–69, 92–94, 134
   generate.py41295%68, 86
   goal.py56395%27–28, 38
   log_handlers.py68790%50–51, 63, 112–116, 125
   proc.py45198%98
   sandbox.py1811592%100–107, 118, 278, 294, 309–311, 327
   typed_client_generation.py80594%55–57, 70, 75
   utils.py18289%27–28
   version_prompt.py73889%27–28, 40, 59–62, 80, 109
src/algokit/core/tasks
   vanity_address.py772962%43–59, 78–97, 141
   wallet.py71593%37, 129, 155–157
TOTAL256926190% 

Tests Skipped Failures Errors Time
343 0 💤 0 ❌ 0 🔥 38.359s ⏱️

@aorumbayev aorumbayev marked this pull request as ready for review October 11, 2023 15:46
@aorumbayev aorumbayev merged commit ec60c63 into feature/tasks Oct 12, 2023
3 checks passed
@aorumbayev aorumbayev deleted the feature/task-send-txn branch October 12, 2023 08:33
aorumbayev added a commit that referenced this pull request Oct 25, 2023
* feat: algokit task - wallet aliasing (#313)

* feat: task wallet aliasing (add, get, remove, reset, list)

* docs: regen docs

* chore: minor tweaks

* chore: pip-audit

* chore: pip audit

* chore: refining aliasing, initial tests

* tests: extra snapshot tests

* docs: adding docs and force flags

* chore: typo fixes

* chore: addressing pr comments

* chore: tweaking docs

* chore: updating docs

* chore: adding extra docs

* chore: fixing artifacts

* feat: algokit task - vanity address (#314)

* feat: implement task vanity_address

* feat: adding logs in the process

* refactor: minor changes on showing result

* chore: fixing mypy

* fix: using mnemonic instead of private key

* test: adding some tests

* chore: updating poetry lock file

* docs: updating generated docs

* test: updating generated tests

* test: updating generated tests

* docs: updating docs

* test: add a test and updating other tests

* chore: fixing tests

* chore: extra tweaks in tests

* test: some minor changes

* chore: minor black formatting

* test: fix the test for windows

* chore: refining codebase; fixing multithreading

* docs: initial docs; to be refined post aliasing pr merge

* chore: fixing windows test

* chore: addressing pr comments

---------

Co-authored-by: Altynbek Orumbayev <[email protected]>

* refactor: adding support for storing vanity to aliases

* docs: refreshing autogenerated docs

* refactor: performance improvements for vanity; swifter termination handling (#319)

* refactor: performance improvements for vanity; swifter termination handling

* chore: graceful termination handling

* chore: fixing test

* feat: algokit task - transfer algo|asa (#315)

* feat: implement task transfer

* chore: fixing typo

* feat: transfer command

* chore: wip refactoring

* feat: unit tests & docs

* chore: poetry tweaks

* chore: updating docs

* chore: minor tweaks

* chore: improving tests; smoke testing

* docs: regen docs

* chore: minor improvements

* build: lock file maintenance

* chore: minor improvements

---------

Co-authored-by: inaie ignacio <[email protected]>

* feat: transaction signing task; polishing tasks (#324)

* feat: transaction signing task; polishing tasks

* docs: adding docstrings; refining task utils

* test: adding snapshot tests

* chore: regen docs

* docs: adding docs

* feat: deploy aliasing support (#323)

* feat: adding aliasing support for deploy command

* docs: updating docs

* docs: regen docs

* chore: minor polishing of click types on tasks

* feat: dispenser fund command aliasing support (#325)

* feat: task send transaction(s) (#326)

* feat: send transaction task

* test: snapshot tests

* docs: regen docs

* docs: adding command docs

* fix: fixing decoding of dictified txns in sign method to support AppCall txns

* chore: addressing pr comments

* feat: ipfs upload (#327)

* feat: ipfs upload

* docs: adding snapshot tests and docs

* docs: regen docs

* chore: mypy tweaks

* chore: pr comment

* feat: nfd domains lookups (#328)

* feat: nfd domains lookups

* chore: pr comments

* docs: regen docs

* chore: mypy tweaks

* feat: task `mint` (arc3 or arc19 compliant) (#329)

* chore: wip arc19 minting

* feat: draft implementation of minting using either arc3 or arc19

* chore: replacing py-multiformats-cid with multiformats

* refactor: addressing pr comments

* test: adding snapshot tests

* docs: adding user facing docs

* feat: task opt in and opt out (#331)

* feat: adding initial optin command

* fix: add network option

* fix: adding help to the opt-in command

* fix: adding network as an argument.

* feat: adding opt in and opt out commands

* chore: update urllib3 for pip audit

* fix: fixing error handling, command order, tests

* docs: updating documents

* test: fixing tests

* refactor: improving tests, adding docs and etc

---------

Co-authored-by: Altynbek Orumbayev <[email protected]>

* chore: minor tweaks in vanity address performance (#333)

* refactor: vanity generation

* chore: wip

* refactor: vanity generation

* chore: refactor vanity generation

* refactor: minor improvements in shared enums; docs

* chore: bumping algokit-utils

* docs: minor adjustments in transfer argument help str

* chore: adjusting docs

* chore: updating lockfile

* chore: apply suggestions from code review

Co-authored-by: Neil Campbell <[email protected]>

---------

Co-authored-by: Negar <[email protected]>
Co-authored-by: inaie ignacio <[email protected]>
Co-authored-by: Neil Campbell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants