Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/split keyreg schemas #9

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Feat/split keyreg schemas #9

merged 2 commits into from
Oct 18, 2023

Conversation

ori-shem-tov
Copy link
Collaborator

Overview

  • Split Key registration schema to online and offline schemas
  • Make nonpart a const in above schemas
  • Modify tests accordingly

@ori-shem-tov ori-shem-tov requested a review from ehanoc October 17, 2023 11:43
ehanoc
ehanoc requested changes Oct 17, 2023
View reviewed changes
lib/algorand.transaction.crafter.spec.ts Outdated Show resolved Hide resolved
@ori-shem-tov ori-shem-tov force-pushed the feat/split-keyreg-schemas branch from 5db28d0 to 371b0ea Compare October 17, 2023 18:54
@ori-shem-tov ori-shem-tov force-pushed the feat/split-keyreg-schemas branch from 371b0ea to 29ac33d Compare October 17, 2023 18:57
@ehanoc ehanoc merged commit 0f4cb16 into main Oct 18, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehanoc ehanoc ehanoc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ori-shem-tov @ehanoc