Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript Pre-Emit Diagnostics #149

Merged
merged 8 commits into from
Oct 13, 2023
Merged

TypeScript Pre-Emit Diagnostics #149

merged 8 commits into from
Oct 13, 2023

Conversation

joe-p
Copy link
Contributor

@joe-p joe-p commented Oct 7, 2023

TypeScript's pre-emit diagnostics (equivalent of tsc --noEmit) are now ran before compilation, throwing an error on any TypeScript error.

Closes #138

@netlify
Copy link

netlify bot commented Oct 7, 2023

Deploy Preview for tealscript ready!

Name Link
🔨 Latest commit 23ed5c8
🔍 Latest deploy log https://app.netlify.com/sites/tealscript/deploys/65288904c57e6000081c0346
😎 Deploy Preview https://deploy-preview-149--tealscript.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joe-p joe-p marked this pull request as draft October 7, 2023 23:04
@joe-p
Copy link
Contributor Author

joe-p commented Oct 7, 2023

I realized that it would be a lot better if I could use something that would work in browser, so I plan on migrating to ts-morph with the virtual file system before merging this

@joe-p joe-p marked this pull request as ready for review October 13, 2023 00:02
@joe-p joe-p merged commit 7f50137 into dev Oct 13, 2023
4 checks passed
@joe-p joe-p deleted the feat/typescript_diags branch December 28, 2023 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript compiler check
1 participant