-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARC-79, extends ARC-26 URI scheme with App NoOp calls #319
Conversation
This ARC proposal extends base ARC-26 URI scheme with missing params required for Algorand application NoOp calls.
ARC-79 extends ARC-26 with application NoOp call params.
Co-authored-by: Stéphane <[email protected]>
Co-authored-by: Stéphane <[email protected]>
its missing the network information.. eg how does the wallet knows if the qr code should be used on mainnet, testnet, aramidmain or voimain? the examples are bad.. quick example: i can create method called i stated this multiple times at the wallet council meethings.. |
Thank you for comments! 1- Since extensions are not intended to change any fundamental property of parent ARC, therefore the problem of NETWORK is not addressable in any extension like ARC79. 2- Regarding examples: ARC-26 ABNF grammar is essentially RFC 3986 and the use of "&" reserved character (e.g., :, /, ?, &, =) is to separate the URL params according to RFC, so if you think that those are bad, feel free to contact RFC and make a PR there. |
If we do URL encode of the params then there is the problem with your examples.. as you state legit example:
however if you do the correct encoding it should be
This faulty examples in arc26 and arc79 just lead to missusage and failure to standardize this protocol. If you really go by the RFC 3986 then fix your examples so that it is obvious how to work with it. Btw there are different interpretations on what should be encoded and what should not. section-2.2 states that characters like [ and ] MUST be encoded and in your examples they are not. And in your attempt to write that all is good you also encode it however in the arc they are not encoded. |
@scholtz , examples are not URI encoded (like all other URI examples) to maintain human readability in the documentation. This is a known practice and is not considered faulty. Using URI encoding functions and tools will take care of that efficiently. |
ARC-79 extends ARC-26 with params required for application NoOp calls.