fix: Repair loading builders without pytest and make code more explic…

…it/safe about such issue
algoo · Nov 16, 2021 · 47517e5 · 47517e5
1 parent 13f2620
commit 47517e5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/preview_generator/preview/builder/document__scribus.py b/preview_generator/preview/builder/document__scribus.py
@@ -10,8 +10,6 @@
 from subprocess import check_output
 import typing
 
-import pytest
-
 from preview_generator.exception import BuilderDependencyNotFound
 from preview_generator.extension import mimetypes_storage
 from preview_generator.preview.builder.document_generic import DocumentPreviewBuilder
@@ -32,7 +30,6 @@
 SCRIPT_PATH = os.path.join(parent_dir, SCRIPT_FOLDER_NAME, SCRIPT_NAME)
 
 
-@pytest.mark.xfail(reason="Broken builder ?")
 class DocumentPreviewBuilderScribus(DocumentPreviewBuilder):
 
     weight = 110

diff --git a/preview_generator/preview/builder_factory.py b/preview_generator/preview/builder_factory.py
@@ -93,7 +93,10 @@ def load_builders(self, force: bool = False) -> None:
             builder_modules = get_builder_modules(builder_folder)
 
             for module_name in builder_modules:
-                import_builder_module(module_name)
+                try:
+                    import_builder_module(module_name)
+                except Exception:
+                    self.logger.critical("Builder {} failed to be loaded".format(module_name))
 
             from preview_generator.preview.generic_preview import PreviewBuilder  # nopep8