Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc 17 add usage documentation #30

Merged
merged 4 commits into from
Jul 8, 2024
Merged

Conversation

ClmntBcqt
Copy link
Contributor

@ClmntBcqt ClmntBcqt commented Jul 5, 2024

#17

@ClmntBcqt ClmntBcqt requested a review from lebouquetin July 5, 2024 14:18
@@ -1,16 +1,13 @@
# JSSG - Jtremesay's Static Site Generator
# JFM-Engine
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an explanation, something like this: jsm-engine is a friendly fork of jssg made in agreement with the JSSG developer because of different goals. See jtremesay/jssg#21

Note: this explanation may be put at the end of the README. This is not the first information the user wants to read (but it's fair to put it on the project readme)

README.md Outdated

Otherwise, you have to configure the following settings :
- `JSSG_DOMAIN` : the domain name of your website, for instance `"https://www.example.com"` (used in sitemap file)
- `JSSG_CONTENT_DIR` : a list of directories where to look for the site content
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: if the var contains a list, then the naming should be explicit: JSSG_CONTENT_DIR -> JSSG_CONTENT_DIRS.

By the way, I suggest to rename it to JFME_CONTENT_DIRS (and JFME_DOMAIN)

@ClmntBcqt ClmntBcqt requested a review from lebouquetin July 8, 2024 10:56
@ClmntBcqt ClmntBcqt merged commit 0748417 into main Jul 8, 2024
2 checks passed
@ClmntBcqt ClmntBcqt deleted the doc__17_add_usage_documentation branch July 8, 2024 11:44
@ClmntBcqt ClmntBcqt mentioned this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants