Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename content_md to content in models #28

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Rename content_md to content in models #28

merged 3 commits into from
Jul 8, 2024

Conversation

ClmntBcqt
Copy link
Contributor

@ClmntBcqt ClmntBcqt commented Jun 28, 2024 •
edited
Loading

#24

@ClmntBcqt ClmntBcqt requested a review from lebouquetin June 28, 2024 14:04
lebouquetin
lebouquetin requested changes Jul 8, 2024
View reviewed changes
Copy link
Member

@lebouquetin lebouquetin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a change request for old hack on templates. Let's check it's not used anymore in templates (search for triple brackets), remove it from source code and we can merge.

jssg/models.py Outdated Show resolved Hide resolved
@ClmntBcqt ClmntBcqt requested a review from lebouquetin July 8, 2024 09:46
lebouquetin
lebouquetin approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@lebouquetin lebouquetin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ClmntBcqt it's ok. I let you resolve conflicts then sqhash & merge.

@ClmntBcqt ClmntBcqt merged commit 72281c2 into main Jul 8, 2024
2 checks passed
@ClmntBcqt ClmntBcqt deleted the fix__24_rename_content_md_to_content branch July 8, 2024 09:55
@ClmntBcqt ClmntBcqt mentioned this pull request Jul 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lebouquetin lebouquetin lebouquetin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ClmntBcqt @lebouquetin