Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test refactoring #253

Merged
merged 2 commits into from
Aug 14, 2018
Merged

Test refactoring #253

merged 2 commits into from
Aug 14, 2018

Conversation

clemfromspace
Copy link
Contributor

@clemfromspace clemfromspace commented May 17, 2018 •
edited
Loading

Some tests refactoring:

  • Use Factory boy, easier to maintain / write / read.
  • Use mock, faster tests.

Next step will be to implement and use the waitTask from the python client, for the tests that really need to wait for the response from Algolia.

@clemfromspace clemfromspace force-pushed the feat/test-refactoring branch 5 times, most recently from 1e8ac1a to 95abb9b Compare May 17, 2018 16:44
@clemfromspace clemfromspace force-pushed the feat/test-refactoring branch from 95abb9b to 49a5a2b Compare August 6, 2018 14:42
@clemfromspace clemfromspace changed the title [WIP/Test] Feat/test refactoring Test refactoring Aug 6, 2018
@clemfromspace clemfromspace force-pushed the feat/test-refactoring branch from 49a5a2b to 262164c Compare August 13, 2018 14:46
@clemfromspace clemfromspace merged commit 262164c into master Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PLNech PLNech PLNech approved these changes

@julienbourdeau julienbourdeau Awaiting requested review from julienbourdeau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clemfromspace @PLNech