Release 4.1.1 (#176)

* Fix for iPad split view bug (#173) * Fixed the iPad animation bug when bulletin shown, also couple deprecation warnings * Updated Changelog * Corrected the available -check * Remove project resources * Update CHANGELOG Co-authored-by: Petri Tilli <[email protected]> Co-authored-by: Alexis Aubry <[email protected]>
alexisakers · May 14, 2020 · 79e5da5 · 79e5da5
1 parent bf67b0b
commit 79e5da5
Show file tree

Hide file tree

Showing 49 changed files with 96 additions and 368 deletions.
diff --git a/.swiftpm/xcode/package.xcworkspace/contents.xcworkspacedata b/.swiftpm/xcode/package.xcworkspace/contents.xcworkspacedata
diff --git a/BLTNBoard.xcodeproj/project.pbxproj b/BLTNBoard.xcodeproj/project.pbxproj
@@ -21,13 +21,9 @@
 		558D808B218DC5B6000ADAFD /* BLTNBoard.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 52D6D97C1BEFF229002C0205 /* BLTNBoard.framework */; };
 		558D8093218DCA81000ADAFD /* FBSnapshotTestCase.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 558D8092218DCA81000ADAFD /* FBSnapshotTestCase.framework */; };
 		558D8095218DCA98000ADAFD /* FBSnapshotTestCase.framework in Embed Frameworks */ = {isa = PBXBuildFile; fileRef = 558D8092218DCA81000ADAFD /* FBSnapshotTestCase.framework */; settings = {ATTRIBUTES = (CodeSignOnCopy, RemoveHeadersOnCopy, ); }; };
-		5590C04B20B852150045C315 /* CloseGlyph.png in Resources */ = {isa = PBXBuildFile; fileRef = 5590C04820B852150045C315 /* CloseGlyph.png */; };
-		5590C04C20B852150045C315 /* [email protected] in Resources */ = {isa = PBXBuildFile; fileRef = 5590C04920B852150045C315 /* [email protected] */; };
-		5590C04D20B852150045C315 /* [email protected] in Resources */ = {isa = PBXBuildFile; fileRef = 5590C04A20B852150045C315 /* [email protected] */; };
 		5590C04F20B85BCE0045C315 /* BLTNTitleLabelContainer.swift in Sources */ = {isa = PBXBuildFile; fileRef = 5590C04E20B85BCE0045C315 /* BLTNTitleLabelContainer.swift */; };
 		5590C05120B934230045C315 /* Highlighter.swift in Sources */ = {isa = PBXBuildFile; fileRef = 5590C05020B934230045C315 /* Highlighter.swift */; };
 		5590C05320B93B350045C315 /* UIColor+Luminance.swift in Sources */ = {isa = PBXBuildFile; fileRef = 5590C05220B93B350045C315 /* UIColor+Luminance.swift */; };
-		5590C05420B93F3A0045C315 /* Localizable.strings in Resources */ = {isa = PBXBuildFile; fileRef = 5590C05620B93F3A0045C315 /* Localizable.strings */; };
 		559F8E95204DB9BA00322949 /* BLTNItem.h in Headers */ = {isa = PBXBuildFile; fileRef = 559F8E94204DB9BA00322949 /* BLTNItem.h */; settings = {ATTRIBUTES = (Public, ); }; };
 		559F8EA3204DC42D00322949 /* UIView+RoundedView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 559F8EA2204DC42D00322949 /* UIView+RoundedView.swift */; };
 		55B3D1CF1FDADA8E00737791 /* AnimationChain.swift in Sources */ = {isa = PBXBuildFile; fileRef = 55B3D1CE1FDADA8E00737791 /* AnimationChain.swift */; };
@@ -90,46 +86,9 @@
 		558D8088218DC5B6000ADAFD /* BLTNBoardTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = BLTNBoardTests.swift; sourceTree = "<group>"; };
 		558D808A218DC5B6000ADAFD /* BLTNBoardTests.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; path = BLTNBoardTests.plist; sourceTree = "<group>"; };
 		558D8092218DCA81000ADAFD /* FBSnapshotTestCase.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = FBSnapshotTestCase.framework; path = Carthage/Build/iOS/FBSnapshotTestCase.framework; sourceTree = "<group>"; };
-		5590C04820B852150045C315 /* CloseGlyph.png */ = {isa = PBXFileReference; lastKnownFileType = image.png; path = CloseGlyph.png; sourceTree = "<group>"; };
-		5590C04920B852150045C315 /* [email protected] */ = {isa = PBXFileReference; lastKnownFileType = image.png; path = "[email protected]"; sourceTree = "<group>"; };
-		5590C04A20B852150045C315 /* [email protected] */ = {isa = PBXFileReference; lastKnownFileType = image.png; path = "[email protected]"; sourceTree = "<group>"; };
 		5590C04E20B85BCE0045C315 /* BLTNTitleLabelContainer.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = BLTNTitleLabelContainer.swift; sourceTree = "<group>"; };
 		5590C05020B934230045C315 /* Highlighter.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = Highlighter.swift; sourceTree = "<group>"; };
 		5590C05220B93B350045C315 /* UIColor+Luminance.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "UIColor+Luminance.swift"; sourceTree = "<group>"; };
-		5590C05520B93F3A0045C315 /* en */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = en; path = en.lproj/Localizable.strings; sourceTree = "<group>"; };
-		5590C05820B93F750045C315 /* fr */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = fr; path = fr.lproj/Localizable.strings; sourceTree = "<group>"; };
-		5590C05920B93F790045C315 /* de */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = de; path = de.lproj/Localizable.strings; sourceTree = "<group>"; };
-		5590C05A20B93FFC0045C315 /* zh-Hans */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = "zh-Hans"; path = "zh-Hans.lproj/Localizable.strings"; sourceTree = "<group>"; };
-		5590C05B20B940190045C315 /* es */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = es; path = es.lproj/Localizable.strings; sourceTree = "<group>"; };
-		5590C05C20B940310045C315 /* it */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = it; path = it.lproj/Localizable.strings; sourceTree = "<group>"; };
-		5590C05D20B940420045C315 /* da */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = da; path = da.lproj/Localizable.strings; sourceTree = "<group>"; };
-		5590C05E20B940590045C315 /* nl */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = nl; path = nl.lproj/Localizable.strings; sourceTree = "<group>"; };
-		5590C05F20B9406C0045C315 /* hr */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = hr; path = hr.lproj/Localizable.strings; sourceTree = "<group>"; };
-		5590C06020B9407A0045C315 /* el */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = el; path = el.lproj/Localizable.strings; sourceTree = "<group>"; };
-		5590C06120B940930045C315 /* he */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = he; path = he.lproj/Localizable.strings; sourceTree = "<group>"; };
-		5590C06220B940AA0045C315 /* ar */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = ar; path = ar.lproj/Localizable.strings; sourceTree = "<group>"; };
-		5590C06320B940B80045C315 /* cs */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = cs; path = cs.lproj/Localizable.strings; sourceTree = "<group>"; };
-		5590C06420B940E50045C315 /* ja */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = ja; path = ja.lproj/Localizable.strings; sourceTree = "<group>"; };
-		5590C06520B940F90045C315 /* ko */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = ko; path = ko.lproj/Localizable.strings; sourceTree = "<group>"; };
-		5590C06620B9410C0045C315 /* th */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = th; path = th.lproj/Localizable.strings; sourceTree = "<group>"; };
-		5590C06720B941150045C315 /* uk */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = uk; path = uk.lproj/Localizable.strings; sourceTree = "<group>"; };
-		5590C06820B9412B0045C315 /* ms */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = ms; path = ms.lproj/Localizable.strings; sourceTree = "<group>"; };
-		5590C06920B941390045C315 /* vi */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = vi; path = vi.lproj/Localizable.strings; sourceTree = "<group>"; };
-		5590C06A20B941440045C315 /* sk */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = sk; path = sk.lproj/Localizable.strings; sourceTree = "<group>"; };
-		5590C06B20B941540045C315 /* ru */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = ru; path = ru.lproj/Localizable.strings; sourceTree = "<group>"; };
-		5590C06C20B9415D0045C315 /* ro */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = ro; path = ro.lproj/Localizable.strings; sourceTree = "<group>"; };
-		5590C06D20B941750045C315 /* ca */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = ca; path = ca.lproj/Localizable.strings; sourceTree = "<group>"; };
-		5590C06E20B941860045C315 /* fi */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = fi; path = fi.lproj/Localizable.strings; sourceTree = "<group>"; };
-		5590C06F20B941990045C315 /* hu */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = hu; path = hu.lproj/Localizable.strings; sourceTree = "<group>"; };
-		5590C07020B941A90045C315 /* id */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = id; path = id.lproj/Localizable.strings; sourceTree = "<group>"; };
-		5590C07120B941BC0045C315 /* nb */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = nb; path = nb.lproj/Localizable.strings; sourceTree = "<group>"; };
-		5590C07220B941CD0045C315 /* pl */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = pl; path = pl.lproj/Localizable.strings; sourceTree = "<group>"; };
-		5590C07320B941DC0045C315 /* pt-BR */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = "pt-BR"; path = "pt-BR.lproj/Localizable.strings"; sourceTree = "<group>"; };
-		5590C07420B941E60045C315 /* pt-PT */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = "pt-PT"; path = "pt-PT.lproj/Localizable.strings"; sourceTree = "<group>"; };
-		5590C07520B942060045C315 /* sv */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = sv; path = sv.lproj/Localizable.strings; sourceTree = "<group>"; };
-		5590C07620B942170045C315 /* tr */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = tr; path = tr.lproj/Localizable.strings; sourceTree = "<group>"; };
-		5590C07720B942620045C315 /* hi */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = hi; path = hi.lproj/Localizable.strings; sourceTree = "<group>"; };
-		5590C07820B943210045C315 /* zh-Hant */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = "zh-Hant"; path = "zh-Hant.lproj/Localizable.strings"; sourceTree = "<group>"; };
 		559F8E94204DB9BA00322949 /* BLTNItem.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = BLTNItem.h; sourceTree = "<group>"; };
 		559F8EA2204DC42D00322949 /* UIView+RoundedView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "UIView+RoundedView.swift"; sourceTree = "<group>"; };
 		55B3D1CE1FDADA8E00737791 /* AnimationChain.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = AnimationChain.swift; sourceTree = "<group>"; };
@@ -178,7 +137,6 @@
 			isa = PBXGroup;
 			children = (
 				5E9D32682108FB9A0032FB06 /* BulletinBoard.podspec */,
-				55E8621C20B84DE500584EAC /* Resources */,
 				8933C7811EB5B7E0000D00A4 /* Sources */,
 				52D6D99C1BEFF38C002C0205 /* Configs */,
 				558D8087218DC5B6000ADAFD /* BLTNBoardTests */,
@@ -221,14 +179,6 @@
 			name = Frameworks;
 			sourceTree = "<group>";
 		};
-		5590C05720B93F610045C315 /* Strings */ = {
-			isa = PBXGroup;
-			children = (
-				5590C05620B93F3A0045C315 /* Localizable.strings */,
-			);
-			path = Strings;
-			sourceTree = "<group>";
-		};
 		55B3D1D01FDD643B00737791 /* Appearance */ = {
 			isa = PBXGroup;
 			children = (
@@ -328,17 +278,6 @@
 			path = ContinuousCorners;
 			sourceTree = "<group>";
 		};
-		55E8621C20B84DE500584EAC /* Resources */ = {
-			isa = PBXGroup;
-			children = (
-				5590C05720B93F610045C315 /* Strings */,
-				5590C04820B852150045C315 /* CloseGlyph.png */,
-				5590C04920B852150045C315 /* [email protected] */,
-				5590C04A20B852150045C315 /* [email protected] */,
-			);
-			path = Resources;
-			sourceTree = "<group>";
-		};
 		8933C7811EB5B7E0000D00A4 /* Sources */ = {
 			isa = PBXGroup;
 			children = (
@@ -485,10 +424,6 @@
 			isa = PBXResourcesBuildPhase;
 			buildActionMask = 2147483647;
 			files = (
-				5590C04D20B852150045C315 /* [email protected] in Resources */,
-				5590C04B20B852150045C315 /* CloseGlyph.png in Resources */,
-				5590C05420B93F3A0045C315 /* Localizable.strings in Resources */,
-				5590C04C20B852150045C315 /* [email protected] in Resources */,
 			);
 			runOnlyForDeploymentPostprocessing = 0;
 		};
@@ -555,50 +490,6 @@
 		};
 /* End PBXTargetDependency section */
 
-/* Begin PBXVariantGroup section */
-		5590C05620B93F3A0045C315 /* Localizable.strings */ = {
-			isa = PBXVariantGroup;
-			children = (
-				5590C05520B93F3A0045C315 /* en */,
-				5590C05820B93F750045C315 /* fr */,
-				5590C05920B93F790045C315 /* de */,
-				5590C05A20B93FFC0045C315 /* zh-Hans */,
-				5590C05B20B940190045C315 /* es */,
-				5590C05C20B940310045C315 /* it */,
-				5590C05D20B940420045C315 /* da */,
-				5590C05E20B940590045C315 /* nl */,
-				5590C05F20B9406C0045C315 /* hr */,
-				5590C06020B9407A0045C315 /* el */,
-				5590C06120B940930045C315 /* he */,
-				5590C06220B940AA0045C315 /* ar */,
-				5590C06320B940B80045C315 /* cs */,
-				5590C06420B940E50045C315 /* ja */,
-				5590C06520B940F90045C315 /* ko */,
-				5590C06620B9410C0045C315 /* th */,
-				5590C06720B941150045C315 /* uk */,
-				5590C06820B9412B0045C315 /* ms */,
-				5590C06920B941390045C315 /* vi */,
-				5590C06A20B941440045C315 /* sk */,
-				5590C06B20B941540045C315 /* ru */,
-				5590C06C20B9415D0045C315 /* ro */,
-				5590C06D20B941750045C315 /* ca */,
-				5590C06E20B941860045C315 /* fi */,
-				5590C06F20B941990045C315 /* hu */,
-				5590C07020B941A90045C315 /* id */,
-				5590C07120B941BC0045C315 /* nb */,
-				5590C07220B941CD0045C315 /* pl */,
-				5590C07320B941DC0045C315 /* pt-BR */,
-				5590C07420B941E60045C315 /* pt-PT */,
-				5590C07520B942060045C315 /* sv */,
-				5590C07620B942170045C315 /* tr */,
-				5590C07720B942620045C315 /* hi */,
-				5590C07820B943210045C315 /* zh-Hant */,
-			);
-			name = Localizable.strings;
-			sourceTree = "<group>";
-		};
-/* End PBXVariantGroup section */
-
 /* Begin XCBuildConfiguration section */
 		52D6D98E1BEFF229002C0205 /* Debug */ = {
 			isa = XCBuildConfiguration;

diff --git a/BLTNBoardTests/BLTNBoardTests.swift b/BLTNBoardTests/BLTNBoardTests.swift
diff --git a/BulletinBoard.podspec b/BulletinBoard.podspec
@@ -18,6 +18,5 @@ Pod::Spec.new do |s|
   s.frameworks  = "UIKit"
   s.documentation_url = "https://alexaubry.github.io/BulletinBoard"
   s.module_name = "BLTNBoard"
-  s.resources = "Resources/**/*.{lproj,png}"
   s.swift_version = "5.0"
 end
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,14 @@
 # _BulletinBoard_ Changelog
 ## Unreleased
 
+## 🔖 v4.1.1
+### Changes
+- Do not use external resources for close button
+
+### Fixes
+- Fix for iPad split view bug
+[#173](https://github.com/alexaubry/BulletinBoard/pull/173)
+
 ## 🔖 v4.1.0
 ### New Features
 - iOS 13 Dark Mode support

diff --git a/Package.swift b/Package.swift
@@ -0,0 +1,19 @@
+// swift-tools-version:5.0
+import PackageDescription
+
+let package = Package(
+    name: "BLTNBoard",
+    products: [
+        .library(
+            name: "BLTNBoard",
+            targets: ["BLTNBoard"]),
+    ],
+    dependencies: [
+    ],
+    targets: [
+        .target(
+            name: "BLTNBoard",
+            dependencies: [],
+            path: "Sources"),
+    ]
+)
diff --git a/Resources/CloseGlyph.png b/Resources/CloseGlyph.png
diff --git a/Resources/[email protected] b/Resources/[email protected]
diff --git a/Resources/[email protected] b/Resources/[email protected]
diff --git a/Resources/Strings/ar.lproj/Localizable.strings b/Resources/Strings/ar.lproj/Localizable.strings
diff --git a/Resources/Strings/ca.lproj/Localizable.strings b/Resources/Strings/ca.lproj/Localizable.strings
diff --git a/Resources/Strings/cs.lproj/Localizable.strings b/Resources/Strings/cs.lproj/Localizable.strings
diff --git a/Resources/Strings/da.lproj/Localizable.strings b/Resources/Strings/da.lproj/Localizable.strings
diff --git a/Resources/Strings/de.lproj/Localizable.strings b/Resources/Strings/de.lproj/Localizable.strings
diff --git a/Resources/Strings/el.lproj/Localizable.strings b/Resources/Strings/el.lproj/Localizable.strings
diff --git a/Resources/Strings/en.lproj/Localizable.strings b/Resources/Strings/en.lproj/Localizable.strings
diff --git a/Resources/Strings/es.lproj/Localizable.strings b/Resources/Strings/es.lproj/Localizable.strings
diff --git a/Resources/Strings/fi.lproj/Localizable.strings b/Resources/Strings/fi.lproj/Localizable.strings
diff --git a/Resources/Strings/fr.lproj/Localizable.strings b/Resources/Strings/fr.lproj/Localizable.strings
diff --git a/Resources/Strings/he.lproj/Localizable.strings b/Resources/Strings/he.lproj/Localizable.strings
diff --git a/Resources/Strings/hi.lproj/Localizable.strings b/Resources/Strings/hi.lproj/Localizable.strings
diff --git a/Resources/Strings/hr.lproj/Localizable.strings b/Resources/Strings/hr.lproj/Localizable.strings
diff --git a/Resources/Strings/hu.lproj/Localizable.strings b/Resources/Strings/hu.lproj/Localizable.strings
diff --git a/Resources/Strings/id.lproj/Localizable.strings b/Resources/Strings/id.lproj/Localizable.strings
diff --git a/Resources/Strings/it.lproj/Localizable.strings b/Resources/Strings/it.lproj/Localizable.strings
diff --git a/Resources/Strings/ja.lproj/Localizable.strings b/Resources/Strings/ja.lproj/Localizable.strings
diff --git a/Resources/Strings/ko.lproj/Localizable.strings b/Resources/Strings/ko.lproj/Localizable.strings
diff --git a/Resources/Strings/ms.lproj/Localizable.strings b/Resources/Strings/ms.lproj/Localizable.strings
diff --git a/Resources/Strings/nb.lproj/Localizable.strings b/Resources/Strings/nb.lproj/Localizable.strings
diff --git a/Resources/Strings/nl.lproj/Localizable.strings b/Resources/Strings/nl.lproj/Localizable.strings