Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hubble CLI to arkade get #712

Merged
merged 1 commit into from
Jul 8, 2022
Merged

Add Hubble CLI to arkade get #712

merged 1 commit into from
Jul 8, 2022

Conversation

recollir
Copy link
Contributor

Description

Added the hubble cli to arkade get

Motivation and Context

I have raised #703 which was given the go ahead in this comment. Hubble can also be seen as the companion cli to the cilium cli that was added with PR #707.

How Has This Been Tested?

Output of the unit test:

❯ go test -v -run Test_DownloadHubble
=== RUN   Test_DownloadHubble
=== RUN   Test_DownloadHubble/darwin_x86_64_v0.10.0
=== RUN   Test_DownloadHubble/darwin_arm64_v0.10.0
=== RUN   Test_DownloadHubble/linux_x86_64_v0.10.0
=== RUN   Test_DownloadHubble/linux_aarch64_v0.10.0
=== RUN   Test_DownloadHubble/ming_x86_64_v0.10.0
--- PASS: Test_DownloadHubble (0.00s)
    --- PASS: Test_DownloadHubble/darwin_x86_64_v0.10.0 (0.00s)
    --- PASS: Test_DownloadHubble/darwin_arm64_v0.10.0 (0.00s)
    --- PASS: Test_DownloadHubble/linux_x86_64_v0.10.0 (0.00s)
    --- PASS: Test_DownloadHubble/linux_aarch64_v0.10.0 (0.00s)
    --- PASS: Test_DownloadHubble/ming_x86_64_v0.10.0 (0.00s)

Output of make e2e:

❯ make e2e|fgrep hubble
=== RUN   Test_CheckTools/Download_of_hubble
=== PAUSE Test_CheckTools/Download_of_hubble
=== CONT  Test_CheckTools/Download_of_hubble
    --- PASS: Test_CheckTools/Download_of_hubble (0.76s)

Output of the dagger script:

image

Are you a GitHub Sponsor yet (Yes/No?)

  • Yes
  • No

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Documentation

  • I have updated the list of tools in README.md if (required) with ./arkade get -o markdown
  • I have updated the list of apps in README.md if (required) with ./arkade install --help

Checklist:

  • My code follows the code style of this project.

  • My change requires a change to the documentation.

  • I have updated the documentation accordingly.

  • I've read the CONTRIBUTION guide

  • I have signed-off my commits with git commit -s

  • I have added tests to cover my changes.

  • All new and existing tests passed.

  • I have tested this on arm, or have added code to prevent deployment

Signed-off-by: Federico Hernandez <[email protected]>
Copy link
Owner

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@alexellis alexellis merged commit e6c1054 into alexellis:master Jul 8, 2022
@alexellis
Copy link
Owner

Thanks for working with us to get this in 👍

@recollir
Copy link
Contributor Author

recollir commented Jul 8, 2022

🙌 Anything else I could look at and give it a try? Some install maybe, or…?

@Shikachuu
Copy link
Contributor

Hey @recollir,
It would be great if you could give a try to update the Mongodb helm chart as briefly described here.
Or you could give a try to update the min.io chart as described here to the non-operator one.

If you would like to work with CLI tools again there are a couple of unresolved old issues: like this or this which can be a chart + a cli tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants