-
-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add containerd for system applications #672
Conversation
cmd/system/containerd.go
Outdated
return err | ||
} | ||
|
||
taskReload := execute.ExecTask{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this differ from what faasd does?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no difference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this PR. Please see comments
eba8f65
to
5ec5800
Compare
Signed-off-by: Czékus Máté <[email protected]>
5ec5800
to
378e253
Compare
@alexellis Done! ✔️ |
// Licensed under the MIT license. See LICENSE file in the project root for full license information. | ||
|
||
// system contains a suite of Sponsored Apps for arkade | ||
// system contains packages for Linux servers and workstations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this copy/paste mistake
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Add containerd for system applications
Motivation and Context
design/approved
by a maintainer (required) Feature: system packages for Linux servers, CI and workstations #654How Has This Been Tested?
Manually tested with all the flags.
Are you a GitHub Sponsor (Yes/No?)
Types of changes
Documentation
./arkade get -o markdown
./arkade install --help
Checklist:
git commit -s