Updated sealed secret app to new style #257

nitishkumar71 · 2020-10-31T03:53:45Z

Description

Updated the code in sealed_secret_app.go

Motivation and Context

I have raised an issue to propose this change (required)
Convert Sealed Secrets App to use "new" pkg/apps/helm_app style #256
[App] Sealed Secrets #220

How Has This Been Tested?

Install sealed secret into cluster arakade install sealed-secrets
Install client-side tool into /usr/local/bin/

GOOS=$(go env GOOS)
GOARCH=$(go env GOARCH)
wget https://github.com/bitnami-labs/sealed-secrets/releases/download/v0.12.4/kubeseal-$GOOS-$GOARCH
sudo install -m 755 kubeseal-$GOOS-$GOARCH /usr/local/bin/kubeseal

Create a sealed secret file

kubectl create secret generic secret-name --dry-run --from-literal=foo=bar -o [json|yaml] | \
 kubeseal \
 --controller-name=sealed-secrets \
 --controller-namespace=default \
 --format [json|yaml] > mysealedsecret.[json|yaml]

Apply the sealed secret

kubectl create -f mysealedsecret.[json|yaml]

Decrypt secret

kubectl get secret secret-name -o [json|yaml]

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I've read the CONTRIBUTION guide
I have signed-off my commits with git commit -s
I have added tests to cover my changes.
All new and existing tests passed.

I have tested this on arm, or have added code to prevent deployment

derek · 2020-10-31T03:53:48Z

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

Waterdrips

LGTM

alexellis · 2020-10-31T13:55:18Z

Sorry this will require a rebase due to #258 being merged.

@Waterdrips what does @nitishkumar71 need to do to rebase this?

Waterdrips · 2020-10-31T14:27:57Z

yep, delete the section at the top with kubeconfig and change it to

kubeConfigPath, _ := command.Flags().GetString("kubeconfig")

Then call options.WithKubeconfigPath(kubeConfigPath) into the installer options section.

This will fix the issue with not using a supplied kubeconfig flag

nitishkumar71 · 2020-10-31T18:22:35Z

yep, delete the section at the top with kubeconfig and change it to
kubeConfigPath, _ := command.Flags().GetString("kubeconfig")
Then call options.WithKubeconfigPath(kubeConfigPath) into the installer options section.

This will fix the issue with not using a supplied kubeconfig flag

@Waterdrips I have made the changes. please review the changes.

Waterdrips · 2020-10-31T21:52:54Z

cmd/apps/sealed_secret_app.go

@@ -36,7 +38,6 @@ func MakeInstallSealedSecrets() *cobra.Command {
 		if err := config.SetKubeconfig(kubeConfigPath); err != nil {


we dont need to set it here, its gets set in the chart app

Thanks for mention. I have made the changes. @Waterdrips

Waterdrips

see comment on last review, no need to set kubeconfig -its done in the chart app

alexellis · 2020-11-02T08:16:26Z

@Waterdrips ready for another review.

alexellis · 2020-11-02T08:17:48Z

cmd/apps/sealed_secret_app.go

+			WithNamespace(namespace).
+			WithHelmPath(path.Join(userPath, ".helm")).
+			WithHelmRepo("stable/sealed-secrets").
+			WithHelmURL("https://charts.helm.sh/stable").


Bitnami should have a new home for the chart. Can you look around and see if you can find it? The "stable helm repo" is going to be deprecated shortly.

alexellis · 2020-11-02T08:26:57Z

FYI https://twitter.com/HelmPack/status/1322224008822202368?s=20

I've also checked the Bitnami Charts repo (nothing there yet) and asked on their #sealed-secrets channel on K8s Slack.

alexellis · 2020-11-02T09:36:57Z

I found out here -> bitnami-labs/sealed-secrets#389

Thanks @mkmik

nitishkumar71 · 2020-11-02T11:00:51Z

I found out here -> bitnami-labs/sealed-secrets#389

Thanks @mkmik

@alexellis Thanks for pointing it out. I think, we should wait for the new chart repo of sealed secrets. What do you suggest?

alexellis · 2020-11-09T15:27:10Z

No, just go ahead. We already have this pointing at the stable repo.

Signed-off-by: Nitishkumar Singh <[email protected]> updated code based on alexellis#258 Signed-off-by: Nitishkumar Singh <[email protected]> removed additional line Signed-off-by: Nitishkumar Singh <[email protected]> removed unwanted line Signed-off-by: Nitishkumar Singh <[email protected]> removed unwanted code Signed-off-by: Nitishkumar Singh <[email protected]> corrected repo path Signed-off-by: Nitishkumar Singh <[email protected]>

alexellis

Approved

alexellis · 2020-11-19T11:40:45Z

In retrospect and due to #274 I think we do need to switch over to the new helm repo, but it should be a one line change if you can work on that today @nitishkumar71 ?

My understanding is that the charts have now moved to https://charts.helm.sh/stable as read-only.

derek bot added the no-dco label Oct 31, 2020

nitishkumar71 force-pushed the sealed_secrets_new_app branch from b1a6996 to 1da711d Compare October 31, 2020 03:54

derek bot removed the no-dco label Oct 31, 2020

Waterdrips approved these changes Oct 31, 2020

View reviewed changes

nitishkumar71 force-pushed the sealed_secrets_new_app branch 2 times, most recently from 18e5d82 to 6777f93 Compare October 31, 2020 18:18

Waterdrips approved these changes Oct 31, 2020

View reviewed changes

Waterdrips suggested changes Oct 31, 2020

View reviewed changes

nitishkumar71 force-pushed the sealed_secrets_new_app branch from 6777f93 to 48cf185 Compare November 1, 2020 04:23

alexellis reviewed Nov 2, 2020

View reviewed changes

nitishkumar71 force-pushed the sealed_secrets_new_app branch from 48cf185 to d8a0c68 Compare November 10, 2020 02:10

nitishkumar71 requested review from Waterdrips and alexellis November 10, 2020 03:43

alexellis approved these changes Nov 19, 2020

View reviewed changes

alexellis merged commit 0f447b5 into alexellis:master Nov 19, 2020

nitishkumar71 mentioned this pull request Nov 19, 2020

Update sealed secret chart repo #278

Closed

nitishkumar71 deleted the sealed_secrets_new_app branch March 16, 2024 13:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated sealed secret app to new style #257

Updated sealed secret app to new style #257

nitishkumar71 commented Oct 31, 2020

derek bot commented Oct 31, 2020

Waterdrips left a comment

alexellis commented Oct 31, 2020

Waterdrips commented Oct 31, 2020

nitishkumar71 commented Oct 31, 2020

Waterdrips Oct 31, 2020

nitishkumar71 Nov 1, 2020

Waterdrips left a comment

alexellis commented Nov 2, 2020

alexellis Nov 2, 2020

alexellis commented Nov 2, 2020

alexellis commented Nov 2, 2020

nitishkumar71 commented Nov 2, 2020

alexellis commented Nov 9, 2020

alexellis left a comment

alexellis commented Nov 19, 2020

		@@ -36,7 +38,6 @@ func MakeInstallSealedSecrets() *cobra.Command {
		if err := config.SetKubeconfig(kubeConfigPath); err != nil {

Updated sealed secret app to new style #257

Updated sealed secret app to new style #257

Conversation

nitishkumar71 commented Oct 31, 2020

Description

Motivation and Context

How Has This Been Tested?

Types of changes

Checklist:

derek bot commented Oct 31, 2020

Waterdrips left a comment

Choose a reason for hiding this comment

alexellis commented Oct 31, 2020

Waterdrips commented Oct 31, 2020

nitishkumar71 commented Oct 31, 2020

Waterdrips Oct 31, 2020

Choose a reason for hiding this comment

nitishkumar71 Nov 1, 2020

Choose a reason for hiding this comment

Waterdrips left a comment

Choose a reason for hiding this comment

alexellis commented Nov 2, 2020

alexellis Nov 2, 2020

Choose a reason for hiding this comment

alexellis commented Nov 2, 2020

alexellis commented Nov 2, 2020

nitishkumar71 commented Nov 2, 2020

alexellis commented Nov 9, 2020

alexellis left a comment

Choose a reason for hiding this comment

alexellis commented Nov 19, 2020