New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various Improvements #3

Open

empijei wants to merge 2 commits into alexanderGugel:master from empijei:master

empijei commented Oct 6, 2019

I added a few tests and refactored code to follow styles specified in go codereview comments.

In details:

Left-aligned "happy path"
Changed nested code in else blocks with early returns
Changed deeply nested if to a switch
Made test failure output expected and gotten value
Added a test case for LRU eviction
Added a test case to check if previously inserted values persist

empijei added 2 commits

October 6, 2019 11:08


          Improved style and tests.

79fc8bb


          Added test case for eviction

00feea6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet