Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ASK_SKIP_DOMAIN_VALIDATION to allow skipping manifest api v… #500

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

doiron
Copy link
Contributor

@doiron doiron commented Dec 11, 2023

…alidation prior to skill enablement

Issue #, if available:

Description of changes:

if attempting to deploy a skill that is anything other than custom or music the domain validation will fail and prevent skill enablement from being attempted. By setting the following env variable, the cli will ignore your manifest domain apis and attempt to enable the skill without any prior checks.

ASK_FORCE_ENABLE

example usage:

ASK_FORCE_ENABLE=1 ask deploy

you'll see a warning show up on the terminal stating that the env variable was detected and validation was skipped

==================== Enable Skill ====================
[Warn]: The ASK_FORCE_ENABLE environment variable is set. Skipping domain validation.

The skill has been enabled.

Note: You should not set this env variable, if you have a smartHome skill or any other skill types known to fail skill enablement. It will just make extra service api calls that will end up failing.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@doiron doiron marked this pull request as ready for review December 11, 2023 20:00
@doiron doiron mentioned this pull request Dec 11, 2023
@CamdenFoucht CamdenFoucht self-requested a review December 11, 2023 20:26
@doiron doiron force-pushed the disable-domain-validation branch from a233ee3 to 487f8db Compare December 11, 2023 21:15
@CamdenFoucht CamdenFoucht merged commit 8c297bf into develop Dec 11, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants