Log worker retry count and retry count exhaustion #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
This looks good to me! Nice that you’ve even added a test for the logs.
How much work would it be to make use of structured logging for the retry counts, so we can filter for e.g. jsonPayload.retry = 0? I think it might be enough to pass it as a keyword argument to the log method…
Oh that's a great idea, it should be straightforward. I'll look into it. |
tillprochaska
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While doing some log forensics recently @tillprochaska and I noticed that it might be helpful to log the current retry count and make it clear when we are giving up on retries.
Although I dislike doing two things in one PR I also changed the worker tests to pytest-style, which I needed for a new test which is using a fixture.