-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docker): do not overide cache with COPY #464
Conversation
What is the impact here? |
No impact in application, however this should in theory speed up deployments and docker builds in CI and locally. I will test it with a dummy staging deploy before this is merged |
Yeah thats what I mean, what is the speedup to build times? |
Worst case before was around 2200s now its around 1500 without being cached. Note: this is worst case due to deployments from local machine that requires QEMU as we are using apple silicon. On CI it should be faster than that due to using an x86 image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great find!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
I was looking into the cargo chef build speeds in CI and found a few interesting things that have been implemented and recommended by the chef project.
this was first proposed in LukeMathWalker/cargo-chef#180 and eventually zcach found a workaround with rzync in the following PR ZcashFoundation/zebra#6934