Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docker): do not overide cache with COPY #464

Merged
merged 3 commits into from
Oct 14, 2023

Conversation

0xfourzerofour
Copy link
Collaborator

I was looking into the cargo chef build speeds in CI and found a few interesting things that have been implemented and recommended by the chef project.

this was first proposed in LukeMathWalker/cargo-chef#180 and eventually zcach found a workaround with rzync in the following PR ZcashFoundation/zebra#6934

Dockerfile Show resolved Hide resolved
@dancoombs
Copy link
Collaborator

What is the impact here?

@0xfourzerofour
Copy link
Collaborator Author

What is the impact here?

No impact in application, however this should in theory speed up deployments and docker builds in CI and locally. I will test it with a dummy staging deploy before this is merged

@dancoombs
Copy link
Collaborator

What is the impact here?

No impact in application, however this should in theory speed up deployments and docker builds in CI and locally. I will test it with a dummy staging deploy before this is merged

Yeah thats what I mean, what is the speedup to build times?

@0xfourzerofour
Copy link
Collaborator Author

What is the impact here?

No impact in application, however this should in theory speed up deployments and docker builds in CI and locally. I will test it with a dummy staging deploy before this is merged

Yeah thats what I mean, what is the speedup to build times?

Worst case before was around 2200s now its around 1500 without being cached. Note: this is worst case due to deployments from local machine that requires QEMU as we are using apple silicon. On CI it should be faster than that due to using an x86 image

Copy link
Collaborator

@alex-miao alex-miao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find!

Copy link
Collaborator

@dancoombs dancoombs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@0xfourzerofour 0xfourzerofour merged commit d6b825c into main Oct 14, 2023
7 checks passed
@0xfourzerofour 0xfourzerofour deleted the josh/cargo-chef-optimisation branch October 14, 2023 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants