feat(traits): update use of ethers Provider and contract binding of entrypoint to use traits #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xfourzerofour
changed the title
0xfourzerofour
force-pushed
the
josh/pl-el
branch
from
a544483
to
c6b56b7
Compare
0xfourzerofour
changed the title
dphilipson
reviewed
Aug 23, 2023
dphilipson
reviewed
Aug 23, 2023
dphilipson
approved these changes
Aug 23, 2023
0xfourzerofour
force-pushed
the
josh/pl-el
branch
from
903a098
to
1f133cd
Compare
dancoombs
reviewed
Aug 24, 2023
| aggregator_address: Address, | ||
| user_op: UserOperation, | ||
| gas_cap: u64, | ||
| ) -> anyhow::Result<AggregatorOut>; |
There was a problem hiding this comment.
Lets move the AggregatorOut definition to this file, since its part of this interface now.
There was a problem hiding this comment.
Unless its used in other places where ProviderLike isn't used, in that case we should move it a level above this.
dancoombs
approved these changes
Aug 24, 2023
0xfourzerofour
force-pushed
the
josh/pl-el
branch
from
1e0296a
to
e146839
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Closes] #267
Proposed Changes
EntrypointLiketo get around the compiler but could most likely remove memory cloning however I don't think that will much memory overhead in this case