Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(protolint): lint proto files, add comments, and add linter #313

Merged
merged 11 commits into from
Aug 22, 2023
Merged

chore(protolint): lint proto files, add comments, and add linter #313

merged 11 commits into from
Aug 22, 2023

Conversation

noam-alchemy
Copy link
Member

@noam-alchemy noam-alchemy commented Aug 21, 2023 •
edited
Loading

[Closes/Fixes] #

Adds documentation to the proto schemas used by Rundler, and adds .proto file linting to the pre-commit checks.

Proposed Changes

0xfourzerofour
0xfourzerofour approved these changes Aug 21, 2023
View reviewed changes
Copy link
Collaborator

@0xfourzerofour 0xfourzerofour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, I have used a similar pattern in the past to have unspecified enums as the 0th enum in proto3 is default

dphilipson
dphilipson approved these changes Aug 21, 2023
View reviewed changes
Copy link
Collaborator

@dphilipson dphilipson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks for making our codebase a better place.

proto/op_pool/op_pool.proto Show resolved Hide resolved
proto/op_pool/op_pool.proto Outdated Show resolved Hide resolved
proto/op_pool/op_pool.proto Outdated Show resolved Hide resolved
proto/op_pool/op_pool.proto Outdated Show resolved Hide resolved
@noam-alchemy noam-alchemy merged commit 0ca9c70 into main Aug 22, 2023
5 checks passed
@noam-alchemy noam-alchemy deleted the nh/documentation branch August 22, 2023 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dancoombs dancoombs dancoombs approved these changes

@dphilipson dphilipson dphilipson approved these changes

@0xfourzerofour 0xfourzerofour 0xfourzerofour approved these changes

@alex-miao alex-miao Awaiting requested review from alex-miao alex-miao is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@noam-alchemy @dphilipson @dancoombs @0xfourzerofour