-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding waitForUserOperationReceipt #1175
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “graphite-merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
@@ -0,0 +1,56 @@ | |||
import type { Chain, Client, Hex, Transport } from "viem"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'Hex' is defined but never used.
@@ -0,0 +1,56 @@ | |||
import type { Chain, Client, Hex, Transport } from "viem"; | |||
import type {WaitForUserOperationTxParameters} from "../types"; | |||
import {isBaseSmartAccountClient} from "../../../client/isSmartAccountClient"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <import/extensions> reported by reviewdog 🐶
Missing file extension for "../../../client/isSmartAccountClient"
import type { Chain, Client, Hex, Transport } from "viem"; | ||
import type {WaitForUserOperationTxParameters} from "../types"; | ||
import {isBaseSmartAccountClient} from "../../../client/isSmartAccountClient"; | ||
import {IncompatibleClientError} from "../../../errors/client"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <import/extensions> reported by reviewdog 🐶
Missing file extension for "../../../errors/client"
import type {WaitForUserOperationTxParameters} from "../types"; | ||
import {isBaseSmartAccountClient} from "../../../client/isSmartAccountClient"; | ||
import {IncompatibleClientError} from "../../../errors/client"; | ||
import {Logger} from "../../../logger"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <import/extensions> reported by reviewdog 🐶
Missing file extension for "../../../logger"
import {isBaseSmartAccountClient} from "../../../client/isSmartAccountClient"; | ||
import {IncompatibleClientError} from "../../../errors/client"; | ||
import {Logger} from "../../../logger"; | ||
import {FailedToFindTransactionError} from "../../../errors/transaction"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'FailedToFindTransactionError' is defined but never used.
import {IncompatibleClientError} from "../../../errors/client"; | ||
import {Logger} from "../../../logger"; | ||
import {FailedToFindTransactionError} from "../../../errors/transaction"; | ||
import {UserOperationReceipt} from "../../../types"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <import/extensions> reported by reviewdog 🐶
Missing file extension for "../../../types"
|
||
import type {Client, Chain, Transport} from "viem"; | ||
import type {WaitForUserOperationTxParameters} from "./types"; | ||
import {UserOperationReceipt} from "../../types"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <import/extensions> reported by reviewdog 🐶
Missing file extension for "../../types"
import type {Client, Chain, Transport} from "viem"; | ||
import type {WaitForUserOperationTxParameters} from "./types"; | ||
import {UserOperationReceipt} from "../../types"; | ||
import {_waitForUserOperationTransaction} from "./internal/waitForUserOperation"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <import/extensions> reported by reviewdog 🐶
Missing file extension for "./internal/waitForUserOperation"
import type {WaitForUserOperationTxParameters} from "./types"; | ||
import {UserOperationReceipt} from "../../types"; | ||
import {_waitForUserOperationTransaction} from "./internal/waitForUserOperation"; | ||
import {FailedToFindTransactionError} from "../../errors/transaction"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <import/extensions> reported by reviewdog 🐶
Missing file extension for "../../errors/transaction"
@@ -5,6 +5,7 @@ import { IncompatibleClientError } from "../../errors/client.js"; | |||
import { FailedToFindTransactionError } from "../../errors/transaction.js"; | |||
import { Logger } from "../../logger.js"; | |||
import type { WaitForUserOperationTxParameters } from "./types.js"; | |||
import {_waitForUserOperationTransaction} from "./internal/waitForUserOperation"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <import/extensions> reported by reviewdog 🐶
Missing file extension for "./internal/waitForUserOperation"
Pull Request Checklist
yarn test
)site
folder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change
)yarn lint:check
) and fix any issues? (yarn lint:write
)PR-Codex overview
This PR focuses on improving the functionality for waiting on user operation receipts in a smart account context. It introduces a new method for handling transaction receipts and refactors existing logic to streamline the process.
Detailed summary
waitForUserOperationReceipt
function to handle user operation receipts._waitForUserOperationTransaction
for fetching transaction receipts with retries.waitForUserOperationTransaction
to utilize_waitForUserOperationTransaction
.waitForUserOperationTransaction
.