Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a Rust typegen bug #964

Merged
merged 1 commit into from
Nov 19, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion alan/src/lntors/typen.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

pub fn ctype_to_rtype(
ctype: &CType,
in_function_type: bool,

Check warning

Code scanning / clippy

parameter is only used in recursion Warning

parameter is only used in recursion

Check warning

Code scanning / clippy

parameter is only used in recursion Warning

parameter is only used in recursion
mut deps: OrderedHashMap<String, String>,
) -> Result<(String, OrderedHashMap<String, String>), Box<dyn std::error::Error>> {
match ctype {
Expand Down Expand Up @@ -154,7 +154,7 @@
_ => CType::fail("Bound types must be strings or rust imports"),
}
}
_ => Ok(("".to_string(), deps)), // TODO: Is this correct?
otherwise => ctype_to_rtype(otherwise, in_function_type, deps),
}
CType::Generic(name, args, _) => Ok((format!("{}<{}>", name, args.join(", ")), deps)),
CType::Binds(n, args) => {
Expand Down
Loading