Make the root scope code more 'normal' looking #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that the root scope doesn't need to export anything since it's always included in the scope hierarchy, so I dropped the essentially useless
exports (after a minor tweak to how thectypesyntax is parsed). Then I realized that the type-operator and function-operator binding can be done before any types or functions are defined, which would then let me use the operators where it makes sense to use them, so I also refactored everything according to that. Then I re-ordered the floating point and integer types and functions according to the new "FUI" ordering I'm going to use for tiebreaker logic in the near future. Finally I added a few more operators where it made sense to me.