Fix a bug in buffer_buffer_shader_timings.ln #942
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized the mistake after I tried to run the earlier version on MacOS and it crashed the machine (!!!) and then realized what I did wrong when I actually printed the buffer once it was in RAM and saw the garbage that was produced, particularly with the first few, which didn't change the buffer at all.
I was accidentally setting the
yMax
to0
, which Vulkan and DirectX decide this means "don't run the shader at all" but Metal decides "run the shader on ALL of the GPU memory address space (afaict) until it messes with something it shouldn't and blows up the machine.This fixes the bug here explicitly, but I need to decide what to do if you call
gFor
with invalid arguments ("correct" the0
to1
?panic!
the program? makegFor
fallible and return an error type?)