Frontend overhaul: Refactor, new data/model entry form and schema changes #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…naming convention)
…alidation step; update tests
Removes item_pages.js
- Bump rjsf version and add the (now) required validator - Login button component - new datasource form: - Add information boxes - Show login button instead of form if not logged in - Persist form data (controlled component) - uiSchema (textarea for description etc)
…tute/scivision into new-entry-form
|
Going to merge this after some discussion yesterday. Additional feedback welcome on this thread after merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes several changes to the frontend, but also adjusts the catalog schema
The schema change potentially breaks some examples, so should make a release and do #624 before merging.
In summary: