Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to 'add entry' form #616

Closed
12 tasks done
ots22 opened this issue Aug 24, 2023 · 2 comments · Fixed by #622
Closed
12 tasks done

Changes to 'add entry' form #616

ots22 opened this issue Aug 24, 2023 · 2 comments · Fixed by #622
Assignees
@ots22
Labels
frontend

Comments

@ots22
Copy link
Member

ots22 commented Aug 24, 2023 •
edited
Loading

(Mark as done when on #622)

  • Documentation general improvements
  • Prompt for login before completing form
  • Make 'Add new entry' button more prominent
    • added a 'contribute' button to the new catalog menu, and renamed 'add new entry' to 'contribute an entry'
  • Add additional tasks (see roadmap)
  • Clarify flow when there isn't a yaml file (new model form in particular - there is box quite far down the form, but several prompts for a link etc)
  • remove:
    • pretrained
    • format
  • some examples of form entries, good and bad (e.g. name of pip package, but don't need pip install ...)
  • store data in the form in case of navigating away from the page
  • don't make 'tags' required
  • include a message in the PR (see below)
  • [ ] Don't redirect to GitHub after the PR is opened - make a page explaining what happened and link to it
  • What if you don't have a GitHub account (link to resource elsewhere)
    • can sign up during the login flow - added a note to prerequisites
  • Intermittent errors from new entry form #618

Nice to have:

  • [ ] pull tags in from GitHub
@aldenc
Copy link
Contributor

aldenc commented Aug 24, 2023 •
edited
Loading

suggested text for new PR generated by Scivision frontend:

This is an automated message from the Scivision frontend:

"Your submission was successful and will be reviewed by the Scivision team and added to the catalog. If we have any questions about your submission we will post them as a comment in this PR."

@aldenc
Copy link
Contributor

aldenc commented Aug 24, 2023

change format requirement under prerequisites

ots22 added a commit that referenced this issue Aug 25, 2023
@ots22
Tags default to empty Tuple (#616, one item)
4e23b6f
ots22 added a commit that referenced this issue Aug 25, 2023
@ots22
Remove 'format', 'labels_required', 'pretrained' catalog fields (#616,…
66034b3 
… one item)
This was referenced Aug 25, 2023
Merged
Closed
@ots22 ots22 added the frontend label Aug 30, 2023
@ots22 ots22 self-assigned this Sep 5, 2023
@ots22 ots22 closed this as completed in #622 Sep 6, 2023
ots22 added a commit that referenced this issue Sep 6, 2023
@ots22
Refactor, new data/model entry form and schema changes (#622)
4bce678 
* Refactor React code (separate file for each component)
* Request 'workflow' scope from user in OAuth - see #618
* Add additional tasks
* Tags default to empty Tuple (#616, one item)
* Remove 'format', 'labels_required', 'pretrained' catalog fields (#616, one item)
* Frontend refactor
* Thumbnail image uploader
* Remove unused images (frontend)
* Update catalog field descriptions; change task and domains to FrozenSet
* Don't use Enum based on default_catalog for projects - use separate validation step; update tests
* Remove hard-coded copy of project_schema.js (now generated)
* Catalog dropdown menu, instead of separate items
* Add extended example to Scivision.Py page
* Load banner image as local webp
* Add headings to model, data, project tabs
* Render markdown in field descriptions
* New model/datasource form commentary
* Persist both model and datasource form data within a browser session
* Add open issue link on PR error
* Update contributing guide to link to add new entry pages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ots22 ots22

Labels
frontend
Projects
No open projects
Scivision fortnightly planning: 2023-08-22 to 2023-09-05
Status: Done
Milestone
No milestone
2 participants
@ots22 @aldenc