Check the versions in use against the latest published versions #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwochner
reviewed
Aug 30, 2023
pwochner
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds checks that compare the CLI and API versions in use to the latest release and display a message if the versions in use are not the latest version.
The API version is checked against the tag of the latest docker image for the API (ignoring .latest and .prerelease to just look at the numbers, which should match the
pyproject.tomlversion number).The CLI is checked against the release tags of the CLI in this repo.
Issues
See alan-turing-institute/RCTab/issues/15
How to run
rctab --versionwill displayYou are using an old version of the RCTab CLI. The latest version is {latest.tag}. Pull the latest version from GitHub (https:://github.com/alan-turing-institute/rctab-cli)if the CLI version does not match the tag of the latest release. I will also displayYou are using an old version of the RCTab API. The latest version is {latest.version}. Restart the webapp in the Azure portal to update to the latest version.if the API version does not match the tag of the latest image on Docker Hub.