Support zero amounts and priority with finance update #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The finance update command checks whether a parameter has been passed and only updates the value if it has. With the previous implementation an existence check is made. This masks out None values, but also masks out zero values. In order to support zero values, an explicit check for None is needed.
This changes the check in this way to allow for a zero amount or zero priority to be passed as a parameter.
Issues
Fixes #24
Reviewer
This change allows zero
priority
andamount
. But maybe other values (ticket
?) should have an explicitNone
check as well? I wasn't certain about this.How to run
Create a finance row (not on a production system):
Get the finance row ID:
Find the finance row just created and replace the
<FIN_ID>
values below with the value shown in thefinance-id
field.Update the amount and priority to attempt to set them to zero:
Check that the
amount
andpriority
are now set to zero: