#69 add apt proxy repo support #70
Conversation
Jbaudon
force-pushed
the
69-apt-proxy-repo
branch
from
813d113 to
50940eb
Compare
There was a problem hiding this comment.
This looks great, thanks so much 🎉.
I will look to test this soon, but I can't make a guarantee right now.
Regarding integration tests, I think the Bats container image is build on Alpine Linux. There is an apt package in their repos. So it might be possible to add tests after running apk add apt in the container build.
nexus_allowlist/settings.py
Outdated
| import os | ||
|
|
||
| PYPI_REMOTE_URL = os.getenv("PYPI_REMOTE_URL", "https://pypi.org/") | ||
| CRAN_REMOTE_URL = os.getenv("CRAN_REMOTE_URL", "https://cran.r-project.org/") | ||
| APT_REMOTE_URL = os.getenv("APT_REMOTE_URL", "http://deb.debian.org/debian") | ||
| APT_DISTRO = os.getenv("APT_DISTRO", "bookworm") | ||
| ALLOWED_ARCHIVES = os.getenv( | ||
| "APT_ALLOWED_ARCHIVES", "main,contrib,non-free-firmware,non-free" | ||
| ).split(",") |
There was a problem hiding this comment.
I think I would prefer these to be passed to the program as arguments, to be consistent.
There was a problem hiding this comment.
It also feels risky because we skip any validation and type checking.
|
Not certain why |
nexus_allowlist/settings.py
Outdated
| PYPI_REMOTE_URL = os.getenv("PYPI_REMOTE_URL", "https://pypi.org/") | ||
| CRAN_REMOTE_URL = os.getenv("CRAN_REMOTE_URL", "https://cran.r-project.org/") |
There was a problem hiding this comment.
I'd want to do these in another PR.
JimMadge
force-pushed
the
69-apt-proxy-repo
branch
from
1c0c846 to
ca48751
Compare
| if repo_type == RepositoryType.APT: | ||
| payload["apt"] = {"distribution": APT_DISTRO, "flat": False} |
There was a problem hiding this comment.
This looks problematic. I think what we probably want to do is pass an object with the repositories actual parameters.
|
I think this has highlighted some areas where the structure of the code (with hard-coded parameters and assumptions) has made it too inflexible. |
Description
Fixes #69
This PR simplifies the installation of Debian packages required by R packages by configuring a Nexus APT proxy repository and updating the related allowlist.
Additionally, it introduces the option to pass certain parameters as environment variables, enabling users to modify the remote source of proxy repositories and specify the APT distribution version. This also allows for the use of private repositories (PyPI, CRAN, or APT) or distributions other than Debian (Ubuntu for instance).
Caveat
I did not implement integration tests because doing so would require modifying the base image to a Debian-based one in integration_tests/Dockerfile. I’m not comfortable making such changes. If you have any suggestions regarding this, I would appreciate your input.