Add multithreaded matmul-c implementation #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llewelld
force-pushed
the
matmul-c-threaded
branch
6 times, most recently
from
7c7dfbb to
67b631e
Compare
llewelld
force-pushed
the
matmul-c-threaded
branch
from
67b631e to
3802c92
Compare
llewelld
force-pushed
the
matmul-c-threaded
branch
from
3802c92 to
1148f74
Compare
llewelld
force-pushed
the
matmul-c-threaded
branch
from
1148f74 to
96bc982
Compare
|
Rebased. |
llewelld
force-pushed
the
matmul-c-threaded
branch
from
96bc982 to
ea63cb1
Compare
|
Rebased. |
|
It's no big deal to have this lingering, but for the sake of keeping things tidy, if anyone fancies reviewing this, please feel free. |
|
I doubt I'll find time in the near future, sorry :( |
|
No worries; thanks @mhauru. |
Adds a CPU-parallel matrix multiplication implementation using a threadpool. Parallelism is intra-matrix (i.e. different parts of a single matrix-multiply operation are performed on different threads) so that threading is transparent to the caller.
Refeactos the codebase to split the tests and benchmarks into separate files. Adds some large matrix multiplication benchmarks for the serial and parallel implementations.
Updates the matmul-c square matrix scaling tests to align with mhauru's Julia tests. The benchmarks now perform 19 test with increasingly large square matrices. Single-threaded and multi-threaded matrix multiplication tests are both performed. The results are stored in the same results.csv file so that everything can be plotted together.
llewelld
force-pushed
the
matmul-c-threaded
branch
from
ea63cb1 to
9397b0b
Compare
|
Rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a CPU-parallel matrix multiplication implementation using a threadpool. Parallelism is intra-matrix (i.e. different parts of a single matrix-multiply operation are performed on different threads) so that threading is transparent to the caller.