Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logging for file shares #2319

Merged
merged 9 commits into from
Nov 29, 2024
Merged

Add logging for file shares #2319

merged 9 commits into from
Nov 29, 2024

Conversation

JimMadge
Copy link
Member

@JimMadge JimMadge commented Nov 28, 2024 •
edited
Loading

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).

🚦 Depends on

#2310

⤴️ Summary

🌂 Related issues

Closes #2318
Contributes to #1922

🔬 Tests

Tested on a fresh SRE deployment

Screenshot 2024-11-29 at 09 44 24

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2024 •
edited
Loading

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  data_safe_haven/infrastructure/programs/sre
  data.py 430, 669
Project Total  

This report was generated by python-coverage-comment-action

@JimMadge JimMadge changed the base branch from develop to blob_logs November 29, 2024 09:09
@JimMadge JimMadge marked this pull request as ready for review November 29, 2024 09:57
@JimMadge JimMadge requested review from a team as code owners November 29, 2024 09:57
@jemrobinson
Copy link
Member

What does this actually log? Is it file creation/deletion etc?

jemrobinson
jemrobinson reviewed Nov 29, 2024
View reviewed changes
Copy link
Member

@jemrobinson jemrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small questions/suggestions but mostly this looks good.

data_safe_haven/infrastructure/programs/declarative_sre.py Show resolved Hide resolved
data_safe_haven/infrastructure/programs/sre/data.py Outdated Show resolved Hide resolved
data_safe_haven/infrastructure/programs/sre/data.py Outdated Show resolved Hide resolved
@JimMadge @jemrobinson
Use Output concat method
da382e0 
Co-authored-by: James Robinson <[email protected]>
@JimMadge
Copy link
Member Author

What does this actually log? Is it file creation/deletion etc?

Yes, the precise details seem to depend on the backend (SMB/NFS) but I can see log events for file/directory access, file creation, file deletion.

Base automatically changed from blob_logs to develop November 29, 2024 14:43
craddm
craddm approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@craddm craddm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JimMadge JimMadge merged commit c7d775c into develop Nov 29, 2024
11 checks passed
@JimMadge JimMadge deleted the file_logs branch November 29, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craddm craddm craddm approved these changes

@jemrobinson jemrobinson Awaiting requested review from jemrobinson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

File share logging
3 participants
@JimMadge @jemrobinson @craddm