Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add firewall logs #2308

Merged
merged 4 commits into from
Nov 28, 2024
Merged

Add firewall logs #2308

merged 4 commits into from
Nov 28, 2024

Conversation

JimMadge
Copy link
Member

@JimMadge JimMadge commented Nov 25, 2024 •
edited
Loading

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).

🚦 Depends on

⤴️ Summary

  • Add diagnostic setting to ingest firewall logs into log analytics workspace
  • Add documentation on the tables with firewall logs

🌂 Related issues

Closes #2307
Contributes to #1922

🔬 Tests

Tested in place.

Diagnostic setting created

Screenshot 2024-11-26 at 10 21 04

Logs in workspace

Screenshot 2024-11-26 at 10 23 13

@github-actions GitHub Actions
Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  data_safe_haven/infrastructure/programs
  declarative_sre.py 167
  data_safe_haven/infrastructure/programs/sre
  firewall.py 40, 339
Project Total  

This report was generated by python-coverage-comment-action

@JimMadge JimMadge marked this pull request as ready for review November 26, 2024 11:00
@JimMadge JimMadge requested review from a team as code owners November 26, 2024 11:00
craddm
craddm approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@craddm craddm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JimMadge JimMadge merged commit 0d79c48 into develop Nov 28, 2024
11 checks passed
@JimMadge JimMadge deleted the firewall_logs branch November 28, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craddm craddm craddm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add firewall logs
2 participants
@JimMadge @craddm