Use Entra ID throughout

[jemrobinson]

✅ Checklist

• You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
• You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
• Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).
• You have marked this pull request as a draft and added '[WIP]' to the title if needed (if you're not yet ready to merge).

⤴️ Summary

Change from using AzureAD to Entra ID throughout

🌂 Related issues

Closes #1664

🔬 Tests

Not tested

[jemrobinson]

@craddm @JimMadge I'm not crazy about having a variable called entra_id_tenant_id. Is there any other name that Microsoft use for this?

[craddm]

@jemrobinson I expect it should just be entra_tenant_id

If an article (a, an, the) or possessive (your, your organization's) precedes (Azure Active Directory (Azure AD), Azure Active Directory, Azure AD, AAD), then replace with Microsoft Entra because it's a feature name. For example:

"an Azure AD tenant" becomes "a Microsoft Entra tenant"
"your organization's Azure AD tenant" becomes "your Microsoft Entra tenant"

https://learn.microsoft.com/en-us/entra/fundamentals/how-to-rename-azure-ad?source=recommendations

See also https://learn.microsoft.com/en-us/entra/fundamentals/how-to-find-tenant

[jemrobinson]

Thanks @craddm! Do you see any other names/variable names that look wrong?

[JimMadge]

@craddm @JimMadge I'm not crazy about having a variable called entra_id_tenant_id. Is there any other name that Microsoft use for this?

That one becomes "Microsoft Entra Tenant ID".

[craddm]

I've highlighted quite a few here - the general rule is if something is a feature, it is just Microsoft Entra <x> rather than Microsoft Entra ID <x>, where if it is the whole product i.e. Azure Active Directory it is Microsoft Entra ID

[JimMadge]

LGTM

[craddm]

LGTM

[jemrobinson]

Thanks both! This was a really irritating one to write and to review.