Separate config classes

[jemrobinson]

✅ Checklist

• You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
• You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
• Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).
• You have marked this pull request as a draft and added '[WIP]' to the title if needed (if you're not yet ready to merge).

⤴️ Summary

Separate out serialisable classes (YAMLSerialisable and AzureSerialisable) and ensure that all config files (config, pulumi and contextsettings) are inheriting from one of these.

🌂 Related issues

n/a

🔬 Tests

Tested locally

[JimMadge]

Can we make sure we have tests for all of these changes.

Maybe we should adjust the triggers so that tests/linting run on PRs to any branch?

[jemrobinson]

Is this already done? The YAMLSerialisable and AzureSerialisable classes aren't intended to be used standalone, and the classes that inherit from them are already tested.

[JimMadge]

Is this already done? The YAMLSerialisable and AzureSerialisable classes aren't intended to be used standalone, and the classes that inherit from them are already tested.

No, there are tests for SerialisableConfig which are broken now.

I think we should still write tests with simple examples of how we expect these classes to be used. You could look at the SerialisableConfig tests for examples.

[jemrobinson]

@JimMadge: I've written some tests, but note that I actually don't expect these classes to be used on their own :)

[JimMadge]

Looks good, a few little things to tidy up.

I've written some tests, but note that I actually don't expect these classes to be used on their own

Yes but I don't think I follow your point. If we were to write an ABC we would still need to test it. I think the model here of making a toy "real class" in the tests is a sensible way to do that and neatly separates testing these classes from our real "real classes".