Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependabot #1827

Merged
merged 15 commits into from
Apr 22, 2024
Merged

Conversation

jemrobinson
Copy link
Member

@jemrobinson jemrobinson commented Apr 19, 2024

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).
  • You have marked this pull request as a draft and added '[WIP]' to the title if needed (if you're not yet ready to merge).

⤴️ Summary

Dependabot is currently failing to correctly update requirements.txt from pyproject.toml (see e.g. #1809). It is also double-processing the requirements under docs.

This PR replaces the Python part of Dependabot's config with the following

  • A new docs environment in pyproject.toml
  • A workflow which uses pip-compile to update requirements.txt and docs/requirements.txt
  • Changes all three update-X workflows to run both on pushes to develop and every week.

🌂 Related issues

Closes #1809

🔬 Tests

Untested

@jemrobinson jemrobinson requested review from a team as code owners April 19, 2024 13:50
Copy link
Member

@JimMadge JimMadge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

A few suggestions.
I would prefer not to run the update workflows periodically and on pushes.

.github/dependabot.yml Outdated Show resolved Hide resolved
.github/workflows/update_python_dependencies.yaml Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
.github/workflows/update_docker_versions.yaml Outdated Show resolved Hide resolved
@jemrobinson jemrobinson requested a review from JimMadge April 19, 2024 15:22
@jemrobinson jemrobinson requested a review from a team April 20, 2024 20:48
@JimMadge JimMadge merged commit ab05930 into alan-turing-institute:develop Apr 22, 2024
10 checks passed
@jemrobinson jemrobinson deleted the fix-dependabot branch May 8, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants