Add local DNS for SRE identity server #1821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jemrobinson
force-pushed
the
1802-add-aci-dns
branch
from
7b4d859 to
678f420
Compare
…n be routed to any available IP by the ApplicationGateway backend pool
jemrobinson
force-pushed
the
1802-add-aci-dns
branch
from
678f420 to
308b145
Compare
jemrobinson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
Enable foobar integrationrather than515 foobar).develop.'[WIP]'to the title if needed (if you're not yet ready to merge).Add a local DNS record for the SRE identity server which points to the Azure Container Instance private IP address. This does not fix the issue identified in #1802 but it means that changes only need to be made in the private DNS zone, which should be easier to do.
🌂 Related issues
Contributes to #1802.
🔬 Tests
Tested on a pre-existing SRE