Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Docker versions script #1775

Merged
merged 4 commits into from
Apr 9, 2024
Merged

Fix Docker versions script #1775

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d3e86bf
:bug: Fix bug in Docker image update script
jemrobinson Apr 8, 2024
542d237
:wrench: Update Docker image update action to run on develop
jemrobinson Apr 8, 2024
1977b03
:bug: Fix crontab entry
jemrobinson Apr 9, 2024
319ee5f
Don't run workflow on pushes
JimMadge Apr 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/scripts/update_docker_versions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ def annotate(
return annotated


for filename in (pathlib.Path("data_safe_haven") / "pulumi").glob("**/*.py"):
for filename in (pathlib.Path("data_safe_haven") / "infrastructure").glob("**/*.py"):
jemrobinson marked this conversation as resolved.
Show resolved Hide resolved
needs_replacement = False
lines = []
with open(filename) as f_pulumi:
Expand All @@ -87,6 +87,8 @@ def annotate(
print(f"Updating {image} from {v_current} to {v_latest} in {filename}") # noqa: T201
needs_replacement = True
output = line.replace(v_current, v_latest)
else:
print(f"Leaving {image} at {v_current} (latest version) in {filename}") # noqa: T201
lines += output

if needs_replacement:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/update_docker_versions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ name: Update Pulumi Docker image versions
# Run workflow on pushes to matching branches
on: # yamllint disable-line rule:truthy
push:
branches: [python-migration]
branches: [develop]
JimMadge marked this conversation as resolved.
Show resolved Hide resolved
schedule:
- cron: "0 0 */7 * *" # run once per week
jemrobinson marked this conversation as resolved.
Show resolved Hide resolved
workflow_dispatch: # allow this workflow to be manually triggered
Expand Down
Loading