-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing DBeaver driver issues on T2+ SREs #1704
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craddm
requested review from
martintoreilly,
jemrobinson and
JimMadge
as code owners
January 15, 2024 15:43
craddm
changed the title
[WIP] Fixing DBeaver driver issues on T2+ SREs
Fixing DBeaver driver issues on T2+ SREs
Jan 16, 2024
JimMadge
requested changes
Jan 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍.
Great work @craddm.
deployment/secure_research_desktop/cloud_init/cloud-init-buildimage-ubuntu-2004.mustache.yaml
Show resolved
Hide resolved
JimMadge
reviewed
Jan 17, 2024
JimMadge
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
Enable foobar integration
rather than515 foobar
).develop
.'[WIP]'
to the title if needed (if you're not yet ready to merge)../tests/AutoFormat_Powershell.ps1 -TargetPath <path to file or directory>
for Powershell).usr/share/dbeaver/
to/usr/share/dbeaver-ce/
, so modifications to theini
file were not correctly applied.driver download
dialog boxes that can appear.Note that this new VM image also includes an up-to-date version of Julia, which address a non-DBeaver related issue.
🌂 Related issues
Closes #1666
Closes #1679 since this also updates Julia to 1.10, which will automatically handle changes in CPU architecture. Thus tests will no longer fail on AMD CPUs.
🔬 Tests
Built a new VM image, deployed it to a Tier 2 SRE, and successfully connected to MSSQL and PostgreSQL databases from the T2 SRE.
Rebuilt docs locally