Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hyphens from SHM and SRE names #1650

Merged
merged 6 commits into from
Oct 20, 2023

Conversation

craddm
Copy link
Contributor

@craddm craddm commented Oct 19, 2023

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).
  • You have marked this pull request as a draft and added '[WIP]' to the title if needed (if you're not yet ready to merge).
  • You have formatted your code using appropriate automated tools (for example ./tests/AutoFormat_Powershell.ps1 -TargetPath <path to file or directory> for Powershell).

⤴️ Summary

Checks for hyphens in SHM and SRE names when creating storage accounts. Hyphens are not allowed in storage account names. It removes them if found, and prints a warning message, but then continues deploying.

🌂 Related issues

Closes #799

🔬 Tests

Deployed an SRE with a hyphen in the name in the config.

Copy link
Member

@JimMadge JimMadge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@craddm craddm merged commit c7a6b6a into alan-turing-institute:develop Oct 20, 2023
10 checks passed
@craddm craddm deleted the reject-hyphen branch October 20, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix hyphens in SRE name
2 participants