Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Pulumi error messages #1624

Merged

Conversation

craddm
Copy link
Contributor

@craddm craddm commented Oct 2, 2023

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).
  • You have marked this pull request as a draft and added '[WIP]' to the title if needed (if you're not yet ready to merge).
  • You have formatted your code using appropriate automated tools (for example ./tests/AutoFormat_Powershell.ps1 -TargetPath <path to file or directory> for Powershell).

⤴️ Summary

Fixes incorrect error messages for the deployment name argument passed to dsh init
Adds an error when the backend has not been initialised before attempting to run commands that rely on it (e.g. dsh admin list-users)

Note - this PR also updates the relevant .devcontainer to Pulumi version 3.80.0

🌂 Related issues

Closes #1623

🔬 Tests

Tested locally:
better error

another better error

@jemrobinson
Copy link
Member

jemrobinson commented Oct 2, 2023

It looks like this has been based off an older branch of python-migration. Possibly this is because you used a newer version of develop?

@craddm
Copy link
Contributor Author

craddm commented Oct 2, 2023

It shouldn't be - I updated my local copy of python-migration and merged it into this branch just before making the PR

Edit: ah, which makes it a mess and hard to see what I actually changed, right

@jemrobinson jemrobinson changed the base branch from python-migration to develop October 2, 2023 15:01
@jemrobinson jemrobinson changed the base branch from develop to python-migration October 2, 2023 15:01
@jemrobinson
Copy link
Member

jemrobinson commented Oct 2, 2023

I've merged develop into the upstream python-migration and now this looks more sensible. hmm, no it doesn't. Can you git reset --hard 283f0e93e to drop your last merge commit?

@craddm craddm force-pushed the fix-error-messages branch from e5f7642 to 283f0e9 Compare October 2, 2023 15:10
Copy link
Member

@jemrobinson jemrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jemrobinson jemrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JimMadge JimMadge merged commit 39dc0d2 into alan-turing-institute:python-migration Oct 5, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants