Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pulumi: Add smoke tests #1614

Conversation

jemrobinson
Copy link
Member

@jemrobinson jemrobinson commented Sep 20, 2023

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).
  • You have marked this pull request as a draft and added '[WIP]' to the title if needed (if you're not yet ready to merge).
  • You have formatted your code using appropriate automated tools (for example ./tests/AutoFormat_Powershell.ps1 -TargetPath <path to file or directory> for Powershell).

⤴️ Summary

  • Add some basic smoke tests (NB. these use the old version of bats available in the Ubuntu repos which has fewer features)
  • Add a FileUpload provider to allow files to be uploaded to VMs that cannot access e.g. raw.githubusercontent.com
  • Add an AzureApi call that runs a remote script, but catches failures caused by existing scripts and retries

🌂 Related issues

Closes #1603

🔬 Tests

Tested on a local deployment

@jemrobinson jemrobinson requested a review from a team September 20, 2023 18:36
@jemrobinson jemrobinson changed the title Add smoke tests Pulumi: Add smoke tests Sep 20, 2023
Copy link
Member

@JimMadge JimMadge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

The Azure API doesn't have a more direct way to write a file to a disk mounted to a VM?
I suppose we use the API here as the machines will not generally be accessible by SSH?

@jemrobinson
Copy link
Member Author

The Azure API doesn't have a more direct way to write a file to a disk mounted to a VM?

No, weirdly not. Maybe they didn't want to write something that would work cross-OS?

I suppose we use the API here as the machines will not generally be accessible by SSH?

That's right - these VMs have a very limited allowed set of connections in and out which only cover internal DSH connections and platform level stuff (like this) which bypasses the NSG rules.

@jemrobinson jemrobinson merged commit 53e53ab into alan-turing-institute:python-migration Sep 25, 2023
6 checks passed
@jemrobinson jemrobinson deleted the 1603-add-smoke-tests branch April 19, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants