Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout for guac postgres queries #1608

Merged

Conversation

craddm
Copy link
Contributor

@craddm craddm commented Sep 19, 2023

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).
  • You have marked this pull request as a draft and added '[WIP]' to the title if needed (if you're not yet ready to merge).
  • You have formatted your code using appropriate automated tools (for example ./tests/AutoFormat_Powershell.ps1 -TargetPath <path to file or directory> for Powershell).

⤴️ Summary

Adds a timeout for PostGRES sockets when Guacamole tries to connect to the database

🌂 Related issues

Closes #1607

🔬 Tests

Copy link
Member

@JimMadge JimMadge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, are we still testing this change?

@jemrobinson
Copy link
Member

Testing is ongoing. @craddm to confirm if/when we're happy.

@craddm
Copy link
Contributor Author

craddm commented Sep 19, 2023

So far so good. Since the issue seems to relate to periods of inactivity, I'd say if everything is still fine tomorrow morning, this has done the trick.

@craddm
Copy link
Contributor Author

craddm commented Sep 20, 2023

No further issues today, so seems like this worked.

@craddm craddm merged commit 64a55d8 into alan-turing-institute:python-migration Sep 20, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants