Skip to content

Commit

Permalink
Merge branch 'release-v5.2.0' into template-checklist
Browse files Browse the repository at this point in the history
  • Loading branch information
JimMadge committed Dec 3, 2024
2 parents a9c7815 + 4409e5c commit 89579f7
Show file tree
Hide file tree
Showing 5 changed files with 29 additions and 27 deletions.
6 changes: 2 additions & 4 deletions .github/ISSUE_TEMPLATE/release_checklist.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,9 @@ Refer to the [Deployment](https://data-safe-haven.readthedocs.io/en/latest/deplo
### For minor releases and above

- [ ] Deploy an SHM from this branch and save a transcript of the deployment logs
- Using the new image, deploy a tier 2 and a tier 3 SRE
- [ ] Save the transcript of your tier 2 SRE deployment
- [ ] Save the transcript of your tier 3 SRE deployment
- [ ] Deploy a tier 2 SRE from this branch and save the transcript of the deployment logs
- [ ] Deploy a tier 3 SRE from this branch and save the transcript of the deployment logs
- [ ] Complete the [Security evaluation checklist](https://data-safe-haven.readthedocs.io/en/latest/deployment/security_checklist.html) from the deployment documentation
- [ ] Add the new versions tag as an active build on [Read The Docs](https://readthedocs.org) (You can add as a hidden build, before release, to preview)

### For major releases only

Expand Down
4 changes: 2 additions & 2 deletions SECURITY.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ All organisations using an earlier version in production should update to the la

| Version | Supported |
| --------------------------------------------------------------------------------------- | ------------------ |
| [5.1.0](https://github.com/alan-turing-institute/data-safe-haven/releases/tag/v5.1.0) | :white_check_mark: |
| < 5.1.0 | :x: |
| [5.2.0](https://github.com/alan-turing-institute/data-safe-haven/releases/tag/v5.1.0) | :white_check_mark: |
| < 5.2.0 | :x: |

## Reporting a Vulnerability

Expand Down
5 changes: 4 additions & 1 deletion docs/source/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,10 @@
# List of patterns, relative to source directory, that match files and
# directories to ignore when looking for source files.
# This pattern also affects html_static_path and html_extra_path.
exclude_patterns = ["**/*.partial.md", "**/security_checklist_template.md"]
exclude_patterns = [
"**/*.partial.md",
"deployment/security_checklist/security_checklist_template.md",
]
# -- Options for HTML output -------------------------------------------------

# The theme to use for HTML and HTML Help pages. See the documentation for
Expand Down
2 changes: 2 additions & 0 deletions docs/source/deployment/security_checklist.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ Work your way through the actions described in each section, taking care to noti
- {{white_check_mark}} This indicates a checklist item for which a screenshot is either not appropriate or difficult
```

You can use {download}`this template Markdown file <./security_checklist/security_checklist_template.md>` to complete the checklist.

## Prerequisites

### Roles
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,26 +17,26 @@ Running on SHM/SREs deployed using commit xxxxxx

- :white_check_mark:/:partly_sunny:/:fast_forward:/:x: Check: Users can reset their own password
- <summary><b>Verify that:</b> User can reset their own password</summary>
<img src=""/>
<img src=""/>
- :white_check_mark:/:partly_sunny:/:fast_forward:/:x: Check: non-registered users cannot connect to any SRE workspace
- <summary> <b>Verify that:</b> User can authenticate but cannot see any workspaces</summary>
<img src=""/>
<img src=""/>
- :white_check_mark:/:partly_sunny:/:fast_forward:/:x: Check: registered users can see SRE workspaces
- <summary> <b>Verify that:</b> User can authenticate and can see workspaces</summary>
<img src=""/>
<img src=""/>
- :white_check_mark:/:partly_sunny:/:fast_forward:/:x: Check: Authenticated user can access workspaces
- <summary> <b>Verify that:</b> You can connect to any workspace</i> </summary>
<img src=""/>
<img src=""/>

### Isolated Network

- :white_check_mark:/:partly_sunny:/:fast_forward:/:x: Fail to connect to the internet from a workspace
- <summary> <b>Verify that:</b> Browsing to the service fails</summary>
<img src=""/>
<img src=""/>
- <summary> <b>Verify that:</b> You cannot access the service using curl</summary>
<img src=""/>
<img src=""/>
- <summary> <b>Verify:</b> You cannot get the IP address for the service using nslookup</summary>
<img src=""/>
<img src=""/>

### User devices

Expand All @@ -58,33 +58,32 @@ Running on SHM/SREs deployed using commit xxxxxx
- Connect to the environment from an IP address that is not allowed but with correct credentials
- :white_check_mark:/:partly_sunny:/:fast_forward:/:x: <b>Verify that:</b> Connection fails

#### Tiers 2+:
#### Tiers 2 and above:

- :white_check_mark:/:partly_sunny:/:fast_forward:/:x: Network rules permit access only from allow-listed IP addresses
- In the Azure portal navigate to the Guacamole application gateway NSG for this SRE shm-<SHM NAME>-sre-<SRE NAME>-nsg-application-gateway
- <summary> <b>Verify that:</b> the NSG has network rules allowing Inbound access from allowed IP addresses only</summary>
<img src=""/>

<img src=""/>
- :white_check_mark:/:partly_sunny:/:fast_forward:/:x: all other NSGs have an inbound Deny All rule and no higher priority rule allowing inbound connections from outside the Virtual Network

### Physical security

#### Tier 3 only

- Attempt to connect to the Tier 3 SRE web client from home using a managed device and the correct VPN connection and credentials.
- :fast_forward: <b>Verify that</b>: connection fails.
- :white_check_mark:/:partly_sunny:/:fast_forward:/:x: <b>Verify that</b>: connection fails.
- Attempt to connect from research office using a managed device and the correct VPN connection and credentials.
- :fast_forward: <b>Verify that</b>: connection succeeds
- :fast_forward: <b>Verify that</b>: the network IP ranges corresponding to the research spaces correspond to those allowed by storage account firewall
- :fast_forward: <b>Verify that</b>: physical measures such as screen adaptions or desk partitions are present if risk of visual eavesdropping is high
- :white_check_mark:/:partly_sunny:/:fast_forward:/:x: <b>Verify that</b>: connection succeeds
- :white_check_mark:/:partly_sunny:/:fast_forward:/:x: <b>Verify that</b>: the network IP ranges corresponding to the research spaces correspond to those allowed by storage account firewall
- :white_check_mark:/:partly_sunny:/:fast_forward:/:x: <b>Verify that</b>: physical measures such as screen adaptions or desk partitions are present if risk of visual eavesdropping is high

### Remote connections

- :white_check_mark:/:partly_sunny:/:fast_forward:/:x: Unable to connect as a user to the remote desktop server via SSH
- <summary> <b>Verify that:</b> SSH login by fully-qualified domain name fails</summary>
<img src=""/>
<img src=""/>
- <summary> <b>Verify that:</b> SSH login by public IP address fails</summary>
<img src=""/>
<img src=""/>

- :white_check_mark:/:partly_sunny:/:fast_forward:/:x: <b>Verify that:</b> the remote desktop web client application gateway (shm-<SHM ID>-sre-<SRE ID>-ag-entrypoint) and the firewall are the only SRE resources with public IP addresses.

Expand Down Expand Up @@ -124,14 +123,14 @@ Running on SHM/SREs deployed using commit xxxxxx

- :white_check_mark:/:partly_sunny:/:fast_forward:/:x: Can install any packages
- <summary> <b>Verify that:</b> pytz can be installed</summary>
<img src=""/>
<img src=""/>
- <summary> <b>Verify that:</b> awscli can be installed</summary>
<img src=""/>
<img src=""/>

#### Tier 3:

- :white_check_mark:/:partly_sunny:/:fast_forward:/:x: Can install only allow-listed packages
- <summary> <b>Verify:</b> pytz can be installed</summary>
<img src=""/>
<img src=""/>
- <summary> <b>Verify:</b> awscli cannot be installed</summary>
<img src=""/>
<img src=""/>

0 comments on commit 89579f7

Please sign in to comment.