Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version via Git tags only #66

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Version via Git tags only #66

merged 1 commit into from
Sep 25, 2024

Conversation

phinate
Copy link
Collaborator

@phinate phinate commented Sep 20, 2024

Using setuptools_scm. Makes our versioning workflow use git tags, which we can control through GitHub releases.

The workflow is:

  • PR(s) get merged
  • Make a github release with a new tag (+ auto-generate release notes)
  • Version will be implicitly updated once you run git pull after the tag creation!
    • you can check this with python -c "import cloudcasting; print(cloudcasting.__version__)" :)

@phinate phinate requested review from IFenton and dfulu September 20, 2024 12:50
@phinate
Copy link
Collaborator Author

phinate commented Sep 20, 2024

Also important: this needs you to always include a patch version, e.g. v3.0.0, or the wrong digit will get updated (see here)

Copy link
Collaborator

@dfulu dfulu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@phinate phinate merged commit a51cc0d into main Sep 25, 2024
7 checks passed
@phinate phinate deleted the git-tag-versioning branch September 25, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants