Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dataloaders #6

Merged
merged 13 commits into from
Jul 29, 2024
Merged

Add dataloaders #6

merged 13 commits into from
Jul 29, 2024

Conversation

dfulu
Copy link
Collaborator

@dfulu dfulu commented Jul 23, 2024

This commit adds basic a basic dataset and dataloader which can be used to train models

@dfulu dfulu requested a review from phinate July 23, 2024 15:43
@dfulu
Copy link
Collaborator Author

dfulu commented Jul 23, 2024

@phinate I think this is a good as I can get it myself. Would really appreciate your review and help

@phinate
Copy link
Collaborator

phinate commented Jul 23, 2024

Thanks @dfulu — I'll take a look and make some changes tomorrow, and tag you here once that's in a state where we might need to pair-program.

@phinate phinate force-pushed the dataloader branch 2 times, most recently from a4fac5b to 16083bb Compare July 24, 2024 14:09
@phinate phinate marked this pull request as ready for review July 26, 2024 15:33
Copy link
Collaborator

@phinate phinate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with the result we got to — let's get this merged. Follow ups:

  • better test coverage
  • add back example notebook

@phinate phinate merged commit 6edb688 into main Jul 29, 2024
3 checks passed
@phinate phinate deleted the dataloader branch July 29, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants