-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validation functions #5
Conversation
filterwarnings = [ | ||
"error", | ||
] | ||
#filterwarnings = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This had to be removed because of a warning stemming from ocf_datapipes
project = "sat_pred" | ||
run_name = "persistence" | ||
|
||
logged_params = {"persistence-method": "last input frame",} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding these extra model parameters to wandb hasn't yet been implemented
Thanks for all your work here @dfulu! Some of your tasks definitely deserve their own issues to collect comments. This is quite a large PR, so it's a bit difficult to parse all the moving parts. How about we split this into separate PRs for (+ relevant tests + examples):
How does that sound? This way, we can make sure each part is properly linted + typechecked as we merge it in. We'll also want to make sure we're doing shape-validations too as we go through. I'm completely open to the nature of the splits you'd prefer semantically! (also, sorry for the late message. Please do not reply outside of your working hours!) |
@phinate, yeh sure. It is rather big. I'll start working to split it up into more manageable chunks |
This pull request adds a draft of the model validation procedure. This includes a data loader to load samples of data.
There are some things that still might need to be addressed and/or discussed:
validation.py
- should it be split upocf_datapipes