Add 2-weekly slicing for 2022 #3
Conversation
|
We should definitely add some tests for this (and the other download functionality) properly to make sure the slicing makes sense. For now I'm happy if a couple people can try downloading it and get the expected result! Maybe choose a large value for |
Co-authored-by: Isabel Fenton <[email protected]>
phinate
force-pushed
the
validation-filtering
branch
from
239ec81 to
be2bf48
Compare
There was a problem hiding this comment.
LGTM. I tried running a few examples and it seems it will work as expected once we change to dayofyear.
It might also be worth adding a message (or maybe an error) if you try to run the valid flag for any year except 2022. Otherwise you might think you'll download two separate identical datasets and think they are different
|
Okay, I've implemented the fix we discussed: we now use a date range as suggested by @dfulu. Please take a look and approve if you're happy! :) |
|
@phinate, this looks really good. I've just got one final comment |
No description provided.