Forecast endpoint #734
Draft
Forecast endpoint #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesbrandreth
force-pushed
the
forecast_endpoint
branch
from
57d9616 to
5c0c328
Compare
jamesbrandreth
force-pushed
the
forecast_endpoint
branch
from
5c0c328 to
010c4f7
Compare
| end_datetime, | ||
| PRODUCTION_STATIC_FEATURES, | ||
| PRODUCTION_DYNAMIC_FEATURES | ||
| ).all() |
There was a problem hiding this comment.
You haven't specified output_type="..." as an argument. At the moment I think it returns a query object. Are you expecting a query?
| results_query = ResultQueryMixin().query_results( | ||
| start=start_datetime, | ||
| upto=end_datetime, | ||
| ).subquery() |
There was a problem hiding this comment.
Or perhaps because this is a subquery? Not a query
There was a problem hiding this comment.
that might be it
|
|
||
| query = results_query.innerjoin( | ||
| instance_query, | ||
| instance_query.c.instance_id == results_query.c.instance_id | ||
| ) |
There was a problem hiding this comment.
Which would mean the type of query is also a subquery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Alters the queries driving the forecast endpoints to filter for the dynamic mrdgp model's predictions.
Type of change
Additional dependencies
Tests
How has the code been tested?
Issues fixes
List any issues this closes:
Checklist
Please ensure you have done the following:
Code conforms to the projects style guidelines
New code documented using google docstyle
Updated documentation of any changed code
Any additional dependencies have been added to the appropriate location (e.g.
setup.pyorrequirements.txt)Unit tests written and passing on local database. Tests should prove that fix is effective or new feature works as expected
Code needs to run on the cluster? Tag database administrator in the pull request review to configure.
Reviewer