✨ Odysseus: Add real-world locations to jamcam detections #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
jamesbrandreth
requested review from
jemrobinson,
OscartGiles and
PatrickOHara
as code owners
The new composite primary key in the video_stats table implies a non-null constraint on some new columns, test was updated to match.
|
@dead-water does this change make sense? |
|
Yes but we're not ready to push to a v4 table quite yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enables the database to hold detections' real-world locations
Type of change
Additional dependencies
Tests
How has the code been tested?
Issues fixes
List any issues this closes:
Checklist
Please ensure you have done the following:
Code conforms to the projects style guidelines
New code documented using google docstyle
Updated documentation of any changed code
Any additional dependencies have been added to the appropriate location (e.g.
setup.pyorrequirements.txt)Unit tests written and passing on local database. Tests should prove that fix is effective or new feature works as expected
Code needs to run on the cluster? Tag database administrator in the pull request review to configure.
Reviewer