Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

same cv splits across models #265

Merged
merged 1 commit into from
Nov 13, 2024
Merged

same cv splits across models #265

merged 1 commit into from
Nov 13, 2024

Conversation

mastoffel
Copy link
Collaborator

@mastoffel mastoffel commented Nov 13, 2024

  • adds random_state() to KFold to have the same splits across models
  • adds checks for cross_validate object, currently only allowing KFold

closes #261

Copy link
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  autoemulate
  compare.py
  utils.py 382
  autoemulate/emulators
  gaussian_process.py
  tests
  test_ui.py
  test_utils.py
Project Total  

This report was generated by python-coverage-comment-action

@mastoffel mastoffel merged commit 5cc7a0f into main Nov 13, 2024
6 checks passed
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.48%. Comparing base (3daa3ed) to head (421b56e).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
autoemulate/utils.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #265      +/-   ##
==========================================
+ Coverage   92.45%   92.48%   +0.03%     
==========================================
  Files          62       62              
  Lines        3618     3635      +17     
==========================================
+ Hits         3345     3362      +17     
  Misses        273      273              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mastoffel mastoffel deleted the cv-fold-standardisation branch December 2, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Models should have the same CV fold datasets
2 participants