Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support loggers in verbose mode #138

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jacksonllee
Copy link

Thank you for this wonderful library!

A print statement is used for the various CleverCSV functions where one can set verbose=True, but a logger is sometimes preferred (if not necessary, especially in a production environment) for its flexibility in stream handling and other features unavailable to print statements. This pull request adds a logger keyword argument alongside the existing verbose, so that a logging.Logger instance can be passed in and used. No code changes are made under clevercsv/console/, as the logger doesn't appear to be relevant to the console use cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant